Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dom spec compliance #80

Closed
wants to merge 156 commits into from
Closed

Dom spec compliance #80

wants to merge 156 commits into from

Conversation

nielsdos
Copy link
Owner

@nielsdos nielsdos commented Dec 14, 2023

TODO:

  • spec links updaten in comments
  • Check for remaining lacking coverge (https://app.codecov.io/github/nielsdos/php-src/blob/dom-spec-compliance/ext%2Fdom%2Fnode.c)
  • meer attribute namespaces in parser?
  • perf check new reconciliation
  • reconcile on import/clone node
  • reconcile adopt node (Checked: this is okay because no ns search is performed if parent is NULL)
  • xml serializer
  • namednodemap fixes
  • setAttributeNode matching???
  • zijn er nog entity decode/encode issues?
  • Moeten attributes de external/internal subset respecten (old dom)?
  • Check interactie met dingen gelijk xml schemas
  • Perhaps the ns attributes should be added in front?
  • SA checks, finish ups

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@6aa8687). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage          ?   71.08%           
=========================================
  Files             ?      813           
  Lines             ?   310408           
  Branches          ?        0           
=========================================
  Hits              ?   220655           
  Misses            ?    89753           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nielsdos nielsdos force-pushed the dom-spec-compliance branch 4 times, most recently from 2cdde4b to c3dfbf5 Compare December 22, 2023 22:32
@nielsdos nielsdos force-pushed the dom-spec-compliance branch 5 times, most recently from c6f38eb to 730d822 Compare December 26, 2023 01:23
@nielsdos nielsdos force-pushed the dom-spec-compliance branch from 0a58e4d to 3cb262b Compare December 26, 2023 14:36
@nielsdos nielsdos force-pushed the dom-spec-compliance branch from adf54b9 to 49fdb61 Compare December 26, 2023 16:34
@nielsdos nielsdos closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants