Code

Dom spec compliance#80

Code

Closed

nielsdos wants to merge 156 commits intomasternielsdos/php-src:masterfrom dom-spec-compliancenielsdos/php-src:dom-spec-complianceCopy head branch name to clipboard

+8,694-1,440

Commits

Commits on Dec 26, 2023

• Add bug list

  nielsdos

  committed
  15cc6bf

  Copy full SHA for 15cc6bf

• Add and adapt helper functions for checking spec compliant mode

  nielsdos

  committed
  edd64f2

  Copy full SHA for edd64f2

• Implement spec-compliant reconciliation

  nielsdos

  committed
  37cf9fe

  Copy full SHA for 37cf9fe

• Add todo

  nielsdos

  committed
  a2c120b

  Copy full SHA for a2c120b

• Fix attribute entity subsitution

  Show description for e0f44c3
  

  nielsdos

  and

  tstarling

  committed
  e0f44c3

  Copy full SHA for e0f44c3

• Fix edge case of splitText() not throwing an exception

  nielsdos

  committed
  b60816c

  Copy full SHA for b60816c

• Move to DOMDocument only

  nielsdos

  committed
  93282e8

  Copy full SHA for 93282e8

• Implement spec checks for createCDATASection

  nielsdos

  committed
  79a712e

  Copy full SHA for 79a712e

• Implement spec checks for createProcessingInstruction

  nielsdos

  committed
  a863648

  Copy full SHA for a863648

• Disable macOS to not burn my action minutes

  nielsdos

  committed
  51bb96d

  Copy full SHA for 51bb96d

• Add additional import test

  nielsdos

  committed
  967610a

  Copy full SHA for 967610a

• Use common API for creating a fully qualified name

  nielsdos

  committed
  e03f624

  Copy full SHA for e03f624

• Implement spec-compliant behaviour for DOMElement::$tagName

  nielsdos

  committed
  a786bc2

  Copy full SHA for a786bc2

• Start of new namespace compatibility implementation

  nielsdos

  committed
  1d9cc68

  Copy full SHA for 1d9cc68

• Use new common namespace API

  nielsdos

  committed
  665392e

  Copy full SHA for 665392e

• Make getAttributeNames() ignore internal namespace declarations in spec mode

  nielsdos

  committed
  27b7f81

  Copy full SHA for 27b7f81

• Use namespace concatenation helper

  nielsdos

  committed
  a976430

  Copy full SHA for a976430

• Add todo

  nielsdos

  committed
  d3756a8

  Copy full SHA for d3756a8

• Implement spec-compliant behaviour for DOMNode::$nodeName

  nielsdos

  committed
  8e881a3

  Copy full SHA for 8e881a3

• Enable test that previously didn't work because of ext/dom spec bugs

  nielsdos

  committed
  0e17ba3

  Copy full SHA for 0e17ba3

• Make createAttributeNs spec compliant

  nielsdos

  committed
  fe61e73

  Copy full SHA for fe61e73

• Fix spec-compliance of setAttributeNode(NS)

  nielsdos

  committed
  ebb7242

  Copy full SHA for ebb7242

• Remove unused code

  nielsdos

  committed
  72683f1

  Copy full SHA for 72683f1

• Make isEqualNode spec compliant after attribute handling change

  nielsdos

  committed
  7fdf0a9

  Copy full SHA for 7fdf0a9

• Fix serialization bug

  nielsdos

  committed
  c39dd8f

  Copy full SHA for c39dd8f

• Add test for legacy entity expansion behaviour

  nielsdos

  committed
  0f2c259

  Copy full SHA for 0f2c259

• Make createElement spec compliant

  nielsdos

  committed
  9d1e258

  Copy full SHA for 9d1e258

• Generalise fast namespace checking

  nielsdos

  committed
  3bbaac7

  Copy full SHA for 3bbaac7

• Make createAttribute() spec compliant

  nielsdos

  committed
  11f89c2

  Copy full SHA for 11f89c2

• Make createElementNS spec compliant

  nielsdos

  committed
  a58e590

  Copy full SHA for a58e590

• Fix crashes

  nielsdos

  committed
  a8541bd

  Copy full SHA for a8541bd

• Fix another crash

  nielsdos

  committed
  a9d150f

  Copy full SHA for a9d150f

• Remove obsolete todo

  nielsdos

  committed
  7410e2a

  Copy full SHA for 7410e2a

• Namespace fixes

  nielsdos

  committed
  8876ed6

  Copy full SHA for 8876ed6

• Make getElementsByTagName spec compliant

  nielsdos

  committed
  e8a13ed

  Copy full SHA for e8a13ed

• Mark date in comment

  nielsdos

  committed
  6a6f0b0

  Copy full SHA for 6a6f0b0

• Make Document::$documentURI spec compliant

  nielsdos

  committed
  881633b

  Copy full SHA for 881633b

• Define namespaces as close to the element as possible

  nielsdos

  committed
  bfd7610

  Copy full SHA for bfd7610

• Make prefix unmodifiable

  nielsdos

  committed
  dee3bcf

  Copy full SHA for dee3bcf

• Fix test case output

  nielsdos

  committed
  b15386e

  Copy full SHA for b15386e

• Move tests

  nielsdos

  committed
  b35d801

  Copy full SHA for b35d801

• Fix spec compliance of pre-insertion validation

  nielsdos

  committed
  ea14436

  Copy full SHA for ea14436

• Remove TODO

  nielsdos

  committed
  8ab0d66

  Copy full SHA for 8ab0d66

• Fix adjacent text merging bug

  nielsdos

  committed
  d5dbeda

  Copy full SHA for d5dbeda

• Add codecov

  nielsdos

  committed
  e7f927d

  Copy full SHA for e7f927d

• Add test for getElementsByTagNameNS

  nielsdos

  committed
  2077720

  Copy full SHA for 2077720

• Tests for isEqualNode

  nielsdos

  committed
  22b3682

  Copy full SHA for 22b3682

• Fix new issues

  nielsdos

  committed
  034018a

  Copy full SHA for 034018a

• Spec compliance part 2 for setAttributeNode

  nielsdos

  committed
  fdffb04

  Copy full SHA for fdffb04

• Make importNode throw when needed

  nielsdos

  committed
  8cecfba

  Copy full SHA for 8cecfba

• Make dtd importable and cloneable

  nielsdos

  committed
  849965c

  Copy full SHA for 849965c

• Make appendChild work with dtd

  nielsdos

  committed
  93d22b7

  Copy full SHA for 93d22b7

• Fix attaching of attributes

  nielsdos

  committed
  41cde48

  Copy full SHA for 41cde48

• Correct condition

  nielsdos

  committed
  c0db8ba

  Copy full SHA for c0db8ba

• Lots of attribute handling fixes

  nielsdos

  committed
  c1dc691

  Copy full SHA for c1dc691

• Make getAttributeNodeNS() spec compliant

  nielsdos

  committed
  f863c9d

  Copy full SHA for f863c9d

• Add test for getAttribute()

  nielsdos

  committed
  e4435a5

  Copy full SHA for e4435a5

• Make getAttributeNS() spec compliant

  nielsdos

  committed
  d6f6fea

  Copy full SHA for d6f6fea

• Avoid copying

  nielsdos

  committed
  5174669

  Copy full SHA for 5174669

• Set fast_unwind_on_malloc=0 for easier debugging

  nielsdos

  committed
  a5660d5

  Copy full SHA for a5660d5

• Fix stream path detection

  nielsdos

  committed
  72c222b

  Copy full SHA for 72c222b

• [ci skip] Add comment

  nielsdos

  committed
  f5aecef

  Copy full SHA for f5aecef

• Avoid allocations

  nielsdos

  committed
  5bb179e

  Copy full SHA for 5bb179e

• Use request allocator if possible

  nielsdos

  committed
  6c1d9f5

  Copy full SHA for 6c1d9f5

• Test hasAttribute

  nielsdos

  committed
  3664f1c

  Copy full SHA for 3664f1c

• Make hasAttributeNS spec compliant

  nielsdos

  committed
  25e9de1

  Copy full SHA for 25e9de1

• Make removeAttribute() spec compliant

  nielsdos

  committed
  4032567

  Copy full SHA for 4032567

• Cleanup

  nielsdos

  committed
  e6d775b

  Copy full SHA for e6d775b

• Make removeAttributeNS() spec compliant

  nielsdos

  committed
  f24d3a5

  Copy full SHA for f24d3a5

• Make setAttribute() spec compliant

  nielsdos

  committed
  b4e3944

  Copy full SHA for b4e3944

• Move setAttributeNS legacy implementation

  nielsdos

  committed
  d9af918

  Copy full SHA for d9af918

• Make setAttributeNS() spec compliant

  nielsdos

  committed
  5a5df88

  Copy full SHA for 5a5df88

• Fixup testcase

  nielsdos

  committed
  3ffb753

  Copy full SHA for 3ffb753

• Specified is always true in modern-day dom

  nielsdos

  committed
  12bc82b

  Copy full SHA for 12bc82b

• Remove TODO, this is unfixable

  nielsdos

  committed
  815ff00

  Copy full SHA for 815ff00

• Not anymore

  nielsdos

  committed
  599eff6

  Copy full SHA for 599eff6

• Cleanup

  nielsdos

  committed
  75e6bda

  Copy full SHA for 75e6bda

• Fix spec compliance of isDefaultNamespace

  nielsdos

  committed
  2513252

  Copy full SHA for 2513252

• Faster textContent write

  nielsdos

  committed
  84d164f

  Copy full SHA for 84d164f

• Fix mistake in setAttributeNS

  nielsdos

  committed
  782a47a

  Copy full SHA for 782a47a

• Make lookupNamespaceURI() spec compliant

  nielsdos

  committed
  f55c5d2

  Copy full SHA for f55c5d2

• Make lookupPrefix() spec compliant

  nielsdos

  committed
  bc94664

  Copy full SHA for bc94664

• Fix name matching of getElementsByTagNameNS

  nielsdos

  committed
  f1b4fb5

  Copy full SHA for f1b4fb5

• Cleanup

  nielsdos

  committed
  c60f7aa

  Copy full SHA for c60f7aa

• Fix setAttribute qualified name matching

  nielsdos

  committed
  54675ce

  Copy full SHA for 54675ce

• Demote DOMNameSpaceNode

  nielsdos

  committed
  829f3d5

  Copy full SHA for 829f3d5

• More namespace tests

  nielsdos

  committed
  fd1325f

  Copy full SHA for fd1325f

• Make replaceChild() spec compliant

  nielsdos

  committed
  d2101f2

  Copy full SHA for d2101f2

• Fix crash

  nielsdos

  committed
  0c0a6bc

  Copy full SHA for 0c0a6bc

• Make toggleAttribute spec compliant

  nielsdos

  committed
  e55bfbe

  Copy full SHA for e55bfbe

• Optimize oldNS use

  nielsdos

  committed
  d1b0130

  Copy full SHA for d1b0130

• Remove useless NULL check

  nielsdos

  committed
  6e5a6da

  Copy full SHA for 6e5a6da

• Remove now-incorrect comment

  nielsdos

  committed
  b858bed

  Copy full SHA for b858bed

• Split out pre-insertion validity check into separate method

  nielsdos

  committed
  d612f0e

  Copy full SHA for d612f0e

• Refactor parentnode.c and bring it closer to spec

  nielsdos

  committed
  5b2ee1e

  Copy full SHA for 5b2ee1e

• Move function

  nielsdos

  committed
  9614ed5

  Copy full SHA for 9614ed5

• Rewrite large parts of parentnode.c to comply with spec

  nielsdos

  committed
  aafc36b

  Copy full SHA for aafc36b

• Fix static analysis complaints

  nielsdos

  committed
  164973c

  Copy full SHA for 164973c

• Make appendChild() spec compliant

  nielsdos

  committed
  5b0774a

  Copy full SHA for 5b0774a

• Fix spec compliance of insertAdjacent methods

  nielsdos

  committed
  097486a

  Copy full SHA for 097486a

• Make nodeValue null for elements

  nielsdos

  committed
  2cadf64

  Copy full SHA for 2cadf64

• Fix issue with document properties and cloneNode

  nielsdos

  committed
  2978190

  Copy full SHA for 2978190

• Make DOMAttr::$name spec compliant

  nielsdos

  committed
  0347800

  Copy full SHA for 0347800

• Fixup attribute tests

  nielsdos

  committed
  234289f

  Copy full SHA for 234289f

• Split off insertBefore

  nielsdos

  committed
  4d58241

  Copy full SHA for 4d58241

• Split off check

  nielsdos

  committed
  cbecdb4

  Copy full SHA for cbecdb4

• Add missing invalidation

  nielsdos

  committed
  bbde46b

  Copy full SHA for bbde46b

• Do step 3 of pre-insert validity anyway for simplicity sake

  nielsdos

  committed
  09b1a60

  Copy full SHA for 09b1a60

• Smarter freeing strategy

  nielsdos

  committed
  93a68f8

  Copy full SHA for 93a68f8

• Implement insertBefore according to spec

  nielsdos

  committed
  8edbc32

  Copy full SHA for 8edbc32

• Fixes to hierarchy checks

  nielsdos

  committed
  00085b6

  Copy full SHA for 00085b6

• Avoid memory allocation

  nielsdos

  committed
  a3d1316

  Copy full SHA for a3d1316

• Fix nodes becoming inaccessible after normalizing

  nielsdos

  committed
  825f5c3

  Copy full SHA for 825f5c3

• Avoid allocation

  nielsdos

  committed
  6470011

  Copy full SHA for 6470011

• Make normalize spec compliant

  nielsdos

  committed
  1c3e877

  Copy full SHA for 1c3e877

• Fix prefix of xmlns after parsing

  nielsdos

  committed
  cd5a31c

  Copy full SHA for cd5a31c

• Fix xlink attribute namespace

  nielsdos

  committed
  88704f3

  Copy full SHA for 88704f3

• Add test for namespaced attributes

  nielsdos

  committed
  db84d63

  Copy full SHA for db84d63

• Normalization tests update

  nielsdos

  committed
  fe60339

  Copy full SHA for fe60339

• Make textContent spec compliant

  nielsdos

  committed
  ddb443b

  Copy full SHA for ddb443b

• Fix negative bounds in insertData

  nielsdos

  committed
  f8c9c53

  Copy full SHA for f8c9c53

• Negative length in insertData

  nielsdos

  committed
  d195f08

  Copy full SHA for d195f08

• Fix replaceData negative count

  nielsdos

  committed
  11cc022

  Copy full SHA for 11cc022

• substringData negative arguments

  nielsdos

  committed
  da04701

  Copy full SHA for da04701

• Fix reconciliation of attributes

  nielsdos

  committed
  a56c659

  Copy full SHA for a56c659

• Fix indent

  nielsdos

  committed
  c0b3c70

  Copy full SHA for c0b3c70

• Move common tree walk code into php_dom_next_in_tree_order()

  nielsdos

  committed
  0527fa5

  Copy full SHA for 0527fa5

• Namespace reconciliation logic for elements

  nielsdos

  committed
  38fe522

  Copy full SHA for 38fe522

• Fix cloning a dtd node

  nielsdos

  committed
  10538e7

  Copy full SHA for 10538e7

• More testing

  nielsdos

  committed
  37a30ee

  Copy full SHA for 37a30ee

• Avoid duplicate work

  nielsdos

  committed
  cb4a602

  Copy full SHA for cb4a602

• Split off function

  nielsdos

  committed
  22da0cc

  Copy full SHA for 22da0cc

• Remove type check for now-unused libxml type

  nielsdos

  committed
  6709fab

  Copy full SHA for 6709fab

• Make DOMNamedNodeMap spec compliant

  nielsdos

  committed
  bd99222

  Copy full SHA for bd99222

• Directly call the right function instead of through the helper

  nielsdos

  committed
  58ccbbf

  Copy full SHA for 58ccbbf

• Smarter mangling

  nielsdos

  committed
  4375fde

  Copy full SHA for 4375fde

• Don't add too many UNEXPECTEDs to avoid moving too much code to cold sections

  nielsdos

  committed
  5e86784

  Copy full SHA for 5e86784

• Make traversal method always inlined

  nielsdos

  committed
  88abc1a

  Copy full SHA for 88abc1a

• Improve performance of reconciliation

  nielsdos

  committed
  4bb4364

  Copy full SHA for 4bb4364

• More test coverage for normalization

  nielsdos

  committed
  384ef92

  Copy full SHA for 384ef92

• Remove dead code

  nielsdos

  committed
  11e9b6c

  Copy full SHA for 11e9b6c

• More testing and get rid of special case

  nielsdos

  committed
  f9b2c12

  Copy full SHA for f9b2c12

• More test coverage

  nielsdos

  committed
  8f15417

  Copy full SHA for 8f15417

• More tests for isDefaultNamespace

  nielsdos

  committed
  145bb64

  Copy full SHA for 145bb64

• Better testing of setAttributeNode

  nielsdos

  committed
  054270b

  Copy full SHA for 054270b

• Comment with more explanation

  nielsdos

  committed
  fcb9b39

  Copy full SHA for fcb9b39

• Minor performance improvements

  nielsdos

  committed
  50ce645

  Copy full SHA for 50ce645

• Import and clone spec compliance fixes

  nielsdos

  committed
  63c3152

  Copy full SHA for 63c3152

• Comments

  nielsdos

  committed
  5ae6647

  Copy full SHA for 5ae6647

• Mark namespace attributes at the front of the attribute list

  nielsdos

  committed
  1d2ac1b

  Copy full SHA for 1d2ac1b

• Implement XML serialization

  nielsdos

  committed
  9081a38

  Copy full SHA for 9081a38

• Propagate save error

  nielsdos

  committed
  68641d3

  Copy full SHA for 68641d3

• Handle errors and encoding

  nielsdos

  committed
  041dbaa

  Copy full SHA for 041dbaa

• Fixes

  nielsdos

  committed
  7930ebb

  Copy full SHA for 7930ebb

• Create namespace of attribtue as close to attribute's element as possible

  nielsdos

  committed
  903eb86

  Copy full SHA for 903eb86

• Add todo

  nielsdos

  committed
  49fdb61

  Copy full SHA for 49fdb61