Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cudf helper dtype_from_column_view import from type to column #2097

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from

Conversation

mroeschke
Copy link
Contributor

Description

I'm removing the cudf._lib.types namespace in rapidsai/cudf#17665, and the functionality used here will be moved to cudf._lib.column

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner January 9, 2025 20:01
Copy link

copy-pr-bot bot commented Jan 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagardner-nv dagardner-nv self-assigned this Jan 9, 2025
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change DO NOT MERGE PR should not be merged; see PR for details Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order skip-ci Optionally Skip CI for this PR labels Jan 9, 2025
@dagardner-nv
Copy link
Contributor

As was discussed offline rapidsai/cudf#17665 is slated for inclusion in cudf v25.02.
These changes will be required for adopting 25.02, and these changes won't work prior to that version.

Placing this on-hold until cudf 25.02 is released.

@dagardner-nv
Copy link
Contributor

cc: @cwharris who will likely be the person dealing with this (hopefully).

@mroeschke
Copy link
Contributor Author

mroeschke commented Jan 15, 2025

Not going to close this PR, but I realized that this might be unnecessary as the Morpheus PR that introduced this code that I'm modifying, #2004, should be removed once Morpheus supports RAPIDS 24.12, and this breaking change will be in 25.02.

Of course best for @cwharris to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DO NOT MERGE PR should not be merged; see PR for details Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order non-breaking Non-breaking change skip-ci Optionally Skip CI for this PR
Projects
Status: Review - Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants