Remove cudf._libs.types.pyx #17665
Remove cudf._libs.types.pyx #17665
Conversation
mroeschke
added
Python
python/cudf/cudf/_lib/column.pyx
Outdated
| @@ -64,6 +62,80 @@ cdef get_element(column_view col_view, size_type index): | |||
| ) | |||
|
|
|||
|
|
|||
| def dtype_from_pylibcudf_column(col): | |||
There was a problem hiding this comment.
| def dtype_from_pylibcudf_column(col): | |
| def dtype_from_pylibcudf_column(Column col not None): |
| ) | ||
| elif cdtype_id == plc.TypeID.STRUCT: | ||
| self._dtype = StructDtype.from_arrow( | ||
| plc.interop.to_arrow(self.c_value).type |
There was a problem hiding this comment.
nit: This now necessitates a device to host copy and synchronisation just to get the type (which is a host-side thing).
There was a problem hiding this comment.
Yeah I was hoping that this would be temporarily OK as I'm aiming remove DeviceScalar (along with this code) by the next release cc @vyasr
There was a problem hiding this comment.
I think that's ok if it's going soon anyway
There was a problem hiding this comment.
I agree, I'm OK leaving this for now in anticipation of the code being removed altogether soon.
| plc.interop.to_arrow(self.c_value).type | ||
| ) | ||
| elif cdtype_id == plc.TypeID.LIST: | ||
| self._dtype = ListDtype.from_arrow(plc.interop.to_arrow(self.c_value).type) |
There was a problem hiding this comment.
nit: same issue here as with structs.
…into cln/cudf/types/2
Co-authored-by: Lawrence Mitchell <[email protected]>
|
/merge |
| cdef dtype_from_lists_column_view(column_view cv) | ||
| cdef dtype_from_column_view(column_view cv) |
There was a problem hiding this comment.
Can we remove these declarations? AFAICT these functions aren't needed outside of column.pyx, and you shouldn't have to declare functions in a pxd file if they aren't going to be cimported into other modules (you do have to declare cdef classes though).
There was a problem hiding this comment.
dtype_from_column_view is actually cimported in Morpheus currently nv-morpheus/Morpheus#2097 but ah yes I suppose dtype_from_lists_column_view didn't need to be defined here
Description
Contributes to #17317
cudf/utils/dtypes.pycudf/_libs/column.pyxChecklist