Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Implement spec: MetricFilter #3235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

otel-metricfilter-fn

7b19eb4
Select commit
Loading
Failed to load commit list.
Open

[SDK] Implement spec: MetricFilter #3235

otel-metricfilter-fn
7b19eb4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 18, 2025 in 1s

87.86% (-0.30%) compared to d19eb32

View this Pull Request on Codecov

87.86% (-0.30%) compared to d19eb32

Details

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.86%. Comparing base (d19eb32) to head (7b19eb4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/metrics/state/metric_collector.cc 97.06% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3235      +/-   ##
==========================================
- Coverage   88.16%   87.86%   -0.30%     
==========================================
  Files         198      199       +1     
  Lines        6224     6346     +122     
==========================================
+ Hits         5487     5575      +88     
- Misses        737      771      +34     
Files with missing lines Coverage Δ
...e/opentelemetry/sdk/metrics/export/metric_filter.h 100.00% <100.00%> (ø)
...opentelemetry/sdk/metrics/export/metric_producer.h 100.00% <100.00%> (ø)
...opentelemetry/sdk/metrics/state/metric_collector.h 100.00% <ø> (ø)
sdk/src/metrics/meter_context.cc 76.06% <100.00%> (ø)
sdk/src/metrics/meter_provider.cc 86.85% <100.00%> (-0.33%) ⬇️
sdk/src/metrics/state/metric_collector.cc 91.53% <97.06%> (+4.43%) ⬆️

... and 10 files with indirect coverage changes