Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update form component types #359

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

chore: update form component types #359

wants to merge 4 commits into from

Conversation

tahmidrahman-dsi
Copy link
Collaborator

ID_READER
LINK_BUTTON
HTTP
ID_VERIFICATION_BANNER

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@euanmillar euanmillar mentioned this pull request Jan 10, 2025
Open
euanmillar
euanmillar reviewed Jan 10, 2025
View reviewed changes
src/form/types/types.ts
export const LINK_BUTTON = 'LINK_BUTTON'
export const ID_READER = 'ID_READER'
export const HTTP = 'HTTP'
export const ID_VERIFICATION_BANNER = 'ID_VERIFICATION_BANNER'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tahmidrahman-dsi dont we also need HIDDEN ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, we definitely need, on it right away

euanmillar
euanmillar reviewed Jan 10, 2025
View reviewed changes
src/form/types/types.ts
| IIDReaderFormField
| ILinkButtonFormField
| IHttpFormField
| IIDVerificationBannerFormField
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need | IHiddenFormField

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euanmillar euanmillar euanmillar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahmidrahman-dsi @euanmillar