-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update form component types #359
Open
tahmidrahman-dsi
wants to merge
4
commits into
develop
Choose a base branch
from
update-form-component-types
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,6 +142,11 @@ export const NID_VERIFICATION_BUTTON = 'NID_VERIFICATION_BUTTON' | |
export const DIVIDER = 'DIVIDER' | ||
export const HEADING3 = 'HEADING3' | ||
export const SIGNATURE = 'SIGNATURE' | ||
export const HIDDEN = 'HIDDEN' | ||
export const LINK_BUTTON = 'LINK_BUTTON' | ||
export const ID_READER = 'ID_READER' | ||
export const HTTP = 'HTTP' | ||
export const ID_VERIFICATION_BANNER = 'ID_VERIFICATION_BANNER' | ||
|
||
export enum RadioSize { | ||
LARGE = 'large', | ||
|
@@ -491,6 +496,55 @@ export interface ISignatureFormField extends IFormFieldBase { | |
)[] | ||
} | ||
|
||
export interface IHiddenFormField extends IFormFieldBase { | ||
type: typeof HIDDEN | ||
} | ||
|
||
export interface IHttpFormField extends IFormFieldBase { | ||
type: typeof HTTP | ||
options: { | ||
url: string | ||
method?: string | ||
headers: Record<string, string> | ||
body?: Record<string, any> | ||
params?: Record<string, any> | ||
} | ||
} | ||
|
||
export interface ILinkButtonFormField extends IFormFieldBase { | ||
type: typeof LINK_BUTTON | ||
icon?: { | ||
desktop: string | ||
mobile: string | ||
} | ||
options: { | ||
url: string | ||
callback: { | ||
trigger: string | ||
params: Record<string, string> | ||
} | ||
} | ||
} | ||
|
||
export interface QRReaderType { | ||
type: 'QR' | ||
} | ||
|
||
type ReaderType = QRReaderType | ILinkButtonFormField | ||
export interface IIDReaderFormField extends IFormFieldBase { | ||
type: typeof ID_READER | ||
dividerLabel: MessageDescriptor | ||
manualInputInstructionLabel: MessageDescriptor | ||
readers: [ReaderType, ...ReaderType[]] | ||
} | ||
|
||
export type BannerType = 'pending' | 'verified' | 'failed' | ||
export interface IIDVerificationBannerFormField extends IFormFieldBase { | ||
type: typeof ID_VERIFICATION_BANNER | ||
bannerType: BannerType | ||
idFieldName: string | ||
} | ||
|
||
export type IFormField = | ||
| ITextFormField | ||
| ITelFormField | ||
|
@@ -524,6 +578,11 @@ export type IFormField = | |
| IDividerField | ||
| IHeading3Field | ||
| ISignatureFormField | ||
| IHiddenFormField | ||
| IIDReaderFormField | ||
| ILinkButtonFormField | ||
| IHttpFormField | ||
| IIDVerificationBannerFormField | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need | IHiddenFormField |
||
|
||
export interface SelectComponentOption { | ||
value: string | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tahmidrahman-dsi dont we also need HIDDEN ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, we definitely need, on it right away