qlty check --all --fix #1197
Merged
qlty check --all --fix #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 2 blocking issues (2 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
qlty-cli/tests/cmd/check/runs_from.in/nested_folder/src/main.rs
Outdated
Show resolved
Hide resolved
brynary
reviewed
Nov 21, 2024
There was a problem hiding this comment.
@lsegal hah, nice.
I am curious how the linters did... Is this PR the literal result of qlty check --all --fix or did you do edits?
From my demo at lunch today I know that the ESLint provided fixes for unused variables lints are not safe. (And I am not sure if they are recorded as unsafe in the data, which would require the --unsafe option to use them.)
|
Oh whoops, I was thinking about the other repo! So I imagine these are mostly Clippy |
|
No edits |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.