qlty check --all --fix

plugins/scripts/fetchLatestVersion/github.ts

@@ -19,7 +19,7 @@ export async function fetchLatestVersionFromGithub(
     throw new Error(`GitHub API request failed with status ${response.status}`);
   }
 
-  const data: any = await response.json();
+  const data = (await response.json()) as { tag_name: string };
 
   const tag = data.tag_name as string;
   if (!tag) {

plugins/scripts/updateLinterVersions.ts

@@ -1,4 +1,4 @@
-import { execSync, ExecException } from "child_process";
+import { execSync } from "child_process";
 import fs from "fs";
 import path from "path";
 import toml from "toml";
@@ -174,4 +174,4 @@ async function main(): Promise<void> {
   }
 }
 
-main();
+void main();

plugins/tests/driver.ts

@@ -172,7 +172,7 @@ export class QltyDriver {
     let output = { stdout: "", stderr: "" };
     let exitCode = 0;
     try {
-      let env = {
+      const env = {
         ...executionEnv(this.sandboxPath ?? ""),
         QLTY_LOG_STDERR: "1",
         QLTY_LOG: process.env.QLTY_LOG ?? "debug",
@@ -192,7 +192,9 @@ export class QltyDriver {
     let outputJson = [];
     try {
       outputJson = JSON.parse(output.stdout);
-    } catch {}
+    } catch {
+      /* empty */
+    }
 
     return this.parseRunResult({
       exitCode,

qlty-analysis/src/git/upstream.rs

@@ -40,10 +40,10 @@ fn infer_upstream(workspace: &Workspace) -> Result<Option<String>> {
 }
 
 fn default_upstream(repo: &Repository) -> Result<Option<String>> {
-    let known_default_branches = vec!["main", "master", "develop"];
+    let known_default_branches = ["main", "master", "develop"];
 
     for branch_name in known_default_branches.iter() {
-        if repo.find_branch(&branch_name, git2::BranchType::Local).is_ok() {
+        if repo.find_branch(branch_name, git2::BranchType::Local).is_ok() {
             debug!("Found {} branch. Using as upstream.", branch_name);
             return Ok(Some(branch_name.to_string()));
         }

qlty-analysis/src/lang.rs

@@ -174,7 +174,7 @@ pub trait Language {
         let cursor = &mut parameters_node.walk();
 
         for parameter_node in parameters_node.named_children(cursor) {
-            let parameter_name = node_source(&parameter_node, &source_file);
+            let parameter_name = node_source(&parameter_node, source_file);
 
             let sanitized_parameter_name = self.sanitize_parameter_name(parameter_name);
             match sanitized_parameter_name {

qlty-analysis/src/lang/kotlin.rs

@@ -281,7 +281,7 @@ impl Language for Kotlin {
     }
 
     fn sanitize_parameter_name(&self, parameter_name: String) -> Option<String> {
-        Some(String::from(parameter_name.split(":").next().unwrap()))
+        Some(String::from(parameter_name.split(':').next().unwrap()))
     }
 
     fn function_name_node<'a>(&'a self, node: &'a Node) -> Node<'a> {

qlty-analysis/src/lang/tsx.rs

@@ -38,8 +38,8 @@ impl Default for TSX {
 
         Self {
             common,
-            field_query: field_query,
-            class_query: class_query,
+            field_query,
+            class_query,
             function_declaration_query,
         }
     }

qlty-analysis/src/report.rs

@@ -92,7 +92,7 @@ impl Report {
             invocation.project_id = self.metadata.project_id.clone();
             invocation.reference = self.metadata.reference.clone();
             invocation.build_id = self.metadata.build_id.clone();
-            invocation.build_timestamp = self.metadata.start_time.clone();
+            invocation.build_timestamp = self.metadata.start_time;
             invocation.commit_sha = self.metadata.revision_oid.clone();
         });
 
@@ -101,14 +101,14 @@ impl Report {
             message.project_id = self.metadata.project_id.clone();
             message.reference = self.metadata.reference.clone();
             message.build_id = self.metadata.build_id.clone();
-            message.build_timestamp = self.metadata.start_time.clone();
+            message.build_timestamp = self.metadata.start_time;
             message.commit_sha = self.metadata.revision_oid.clone();
         });
 
         self.issues.par_iter_mut().for_each(|issue| {
             issue.workspace_id = self.metadata.workspace_id.clone();
             issue.project_id = self.metadata.project_id.clone();
-            issue.analyzed_at = Some(self.metadata.start_time.clone().unwrap());
+            issue.analyzed_at = Some(self.metadata.start_time.unwrap());
             issue.pull_request_number = self.metadata.pull_request_number.clone();
             issue.tracked_branch_id = self.metadata.tracked_branch_id.clone();
 
@@ -120,7 +120,7 @@ impl Report {
         self.stats.par_iter_mut().for_each(|stats| {
             stats.workspace_id = self.metadata.workspace_id.clone();
             stats.project_id = self.metadata.project_id.clone();
-            stats.analyzed_at = Some(self.metadata.start_time.clone().unwrap());
+            stats.analyzed_at = Some(self.metadata.start_time.unwrap());
             stats.pull_request_number = self.metadata.pull_request_number.clone();
             stats.tracked_branch_id = self.metadata.tracked_branch_id.clone();
 
@@ -136,7 +136,7 @@ impl Report {
             .filter(|issue| issue.tool == "qlty" && issue.driver == "duplication")
             .fold(HashMap::new(), |mut acc, issue| {
                 let structural_hash = issue.get_property_string("structural_hash");
-                let issues = acc.entry(structural_hash).or_insert(vec![]);
+                let issues = acc.entry(structural_hash).or_default();
                 issues.push(issue.clone());
                 acc
             })

qlty-analysis/src/utils/fs.rs

@@ -27,8 +27,7 @@ pub fn path_to_string<'path>(path: impl AsRef<Path>) -> String {
 
 pub fn path_to_native_string(path: impl AsRef<Path>) -> String {
     path_to_string(path)
-        .replace('\\', MAIN_SEPARATOR_STR)
-        .replace('/', MAIN_SEPARATOR_STR)
+        .replace(['\\', '/'], MAIN_SEPARATOR_STR)
 }
 
 mod test {

qlty-analysis/src/workspace_entries/target_mode.rs

@@ -1,19 +1,17 @@
 use crate::git::DiffMode;
 
 #[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Default)]
 pub enum TargetMode {
+    #[default]
     All,
     Sample(usize),
     Paths(usize),
     UpstreamDiff(String),
     HeadDiff,
 }
 
-impl Default for TargetMode {
-    fn default() -> Self {
-        TargetMode::All
-    }
-}
+
 
 impl TargetMode {
     pub fn diff_mode(&self) -> DiffMode {

qlty-check/src/executor.rs

@@ -98,7 +98,7 @@ impl Executor {
             .invocations
             .iter()
             .for_each(|invocation: &InvocationPlan| {
-                if let Some(_) = &invocation.driver.prepare_script {
+                if invocation.driver.prepare_script.is_some() {
                     // Prevent multiple prepare scripts for the same driver and plugin and
                     // store invocation plan to run the prepare script later
                     prepare_scripts.insert(invocation.invocation_label(), invocation);
@@ -107,7 +107,7 @@ impl Executor {
 
         for (key, invocation) in prepare_scripts {
             let task = self.progress.task(&key, "Running prepare script...");
-            invocation.driver.run_prepare_script(&invocation, &task)?;
+            invocation.driver.run_prepare_script(invocation, &task)?;
             task.clear();
         }
 
@@ -263,7 +263,7 @@ impl Executor {
 
         for config_file in &repository_config_files {
             if let Err(err) = load_config_file_from_repository(
-                &config_file,
+                config_file,
                 &self.plan.workspace,
                 &self.plan.staging_area.destination_directory,
             ) {

qlty-check/src/executor/driver.rs

@@ -380,7 +380,7 @@ impl Driver {
                 "{}/",
                 target_root
                     .strip_prefix("/private/")
-                    .unwrap_or(&target_root)
+                    .unwrap_or(target_root)
             ))
             .unwrap_or(&path)
             .into();
@@ -406,7 +406,7 @@ impl Driver {
 
     fn parser(&self) -> Box<dyn Parser> {
         let parser: Box<dyn Parser> = match self.output_format {
-            OutputFormat::Eslint => Box::new(Eslint::default()),
+            OutputFormat::Eslint => Box::<Eslint>::default(),
             OutputFormat::Hadolint => Box::new(Hadolint {}),
             OutputFormat::Markdownlint => Box::new(Markdownlint {}),
             OutputFormat::Mypy => Box::new(Mypy {}),
@@ -422,7 +422,7 @@ impl Driver {
             OutputFormat::Trufflehog => Box::new(Trufflehog {}),
             OutputFormat::Tsc => Box::new(Tsc {}),
             OutputFormat::Bandit => Box::new(Bandit {}),
-            OutputFormat::Clippy => Box::new(Clippy::default()),
+            OutputFormat::Clippy => Box::<Clippy>::default(),
             OutputFormat::Ripgrep => Box::new(Ripgrep {}),
             OutputFormat::Phpstan => Box::new(Phpstan {}),
             OutputFormat::PhpCodesniffer => Box::new(PhpCodesniffer {}),
@@ -432,29 +432,17 @@ impl Driver {
             OutputFormat::GolangciLint => Box::new(GolangciLint {}),
 
             OutputFormat::Sarif => {
-                let level = match self.output_level {
-                    Some(output_level) => Some(output_level.into()),
-                    None => None,
-                };
+                let level = self.output_level.map(|output_level| output_level.into());
 
-                let category = match self.output_category {
-                    Some(output_category) => Some(output_category.into()),
-                    None => None,
-                };
+                let category = self.output_category.map(|output_category| output_category.into());
 
                 Box::new(Sarif::new(level, category))
             }
 
             OutputFormat::Regex => {
-                let level = match self.output_level {
-                    Some(output_level) => Some(output_level.into()),
-                    None => None,
-                };
-
-                let category = match self.output_category {
-                    Some(output_category) => Some(output_category.into()),
-                    None => None,
-                };
+                let level = self.output_level.map(|output_level| output_level.into());
+
+                let category = self.output_category.map(|output_category| output_category.into());
 
                 let regex = &self
                     .output_regex

qlty-check/src/executor/invocation_result.rs

@@ -45,7 +45,7 @@ impl InvocationResult {
         output: &Output,
         duration: f64,
     ) -> Result<Self> {
-        let exec_result = ExecResult::from_process_output(&output);
+        let exec_result = ExecResult::from_process_output(output);
 
         let now = Utc::now();
         let start_time = now - chrono::Duration::seconds(duration as i64);

qlty-check/src/parser/clippy.rs

@@ -40,8 +40,7 @@ impl ClippyIssue {
                 .split(' ')
                 .last()
                 .unwrap()
-                .replace('(', "")
-                .replace(')', "");
+                .replace(['(', ')'], "");
             if let Ok(url) = Url::parse(&package_id) {
                 self.package_name = url.path_segments().unwrap().last().unwrap().to_string();
             }
@@ -136,7 +135,7 @@ impl Parser for Clippy {
 
             let message = clippy_issue.message.as_ref().unwrap();
             let code = message.code.clone();
-            let suggestion = self.build_suggestion(&message, &clippy_issue);
+            let suggestion = self.build_suggestion(message, &clippy_issue);
 
             let issue = Issue {
                 tool: "clippy".into(),
@@ -182,8 +181,7 @@ impl Clippy {
             .children
             .iter()
             .filter(|child| child.level == "help")
-            .map(|child| self.collect_replacements(&child, issue))
-            .flatten()
+            .flat_map(|child| self.collect_replacements(child, issue))
             .collect();
 
         if replacements.is_empty() {

qlty-check/src/parser/eslint.rs

@@ -165,7 +165,7 @@ fn category(rule_key: &str) -> Category {
 }
 
 fn generate_document_url(rule_key: String) -> String {
-    let rule_config: Vec<&str> = rule_key.split("/").collect();
+    let rule_config: Vec<&str> = rule_key.split('/').collect();
 
     match rule_config.as_slice() {
         [_] => {

qlty-check/src/parser/markdownlint.rs

@@ -71,8 +71,8 @@ fn generate_document_url(rule_key: String) -> String {
         .to_string()
         .replace(
         "${rule}",
-        &rule_key
-            .split(" ")
+        rule_key
+            .split(' ')
             .next()
             .unwrap_or_else(|| &rule_key)
     )

qlty-check/src/parser/regex.rs

@@ -105,7 +105,7 @@ impl Regex {
         if issue.tool == "yamllint" {
             issue.documentation_url = format!(
                 "https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.{}",
-                issue.rule_key.replace("-", "_")
+                issue.rule_key.replace('-', "_")
             );
         }
     }

qlty-check/src/parser/sarif.rs

@@ -267,7 +267,7 @@ impl Parser for Sarif {
                     rule_key,
                     message: result.message.text.clone(),
                     category: self.category.unwrap_or(Category::Lint).into(),
-                    level: self.get_level(&result, &rule_info).into(),
+                    level: self.get_level(result, &rule_info).into(),
                     location,
                     ..Default::default()
                 };

qlty-check/src/parser/trufflehog.rs

@@ -40,14 +40,10 @@ impl Parser for Trufflehog {
             let parsed_data: Output =
                 serde_json::from_str(trufflehog_source.trim()).expect("Error parsing JSON data");
 
-            let range = if let Some(line) = parsed_data.source_metadata.data.filesystem.line {
-                Some(Range {
+            let range = parsed_data.source_metadata.data.filesystem.line.map(|line| Range {
                     start_line: line + 1,
                     ..Default::default()
-                })
-            } else {
-                None
-            };
+                });
 
             let issue = Issue {
                 tool: "trufflehog".into(),

qlty-check/src/parser/tsc.rs

@@ -27,24 +27,24 @@ impl Parser for Tsc {
             let check_string = parts[1];
             let message = parts[2];
 
-            let location_parts: Vec<&str> = location_string.splitn(2, "(").collect();
+            let location_parts: Vec<&str> = location_string.splitn(2, '(').collect();
             if location_parts.len() != 2 {
                 trace!("Location does not have 2 parts splitting on (: {}", line);
                 continue;
             }
 
             let path = location_parts[0];
-            let location_parts: Vec<&str> = location_parts[1].splitn(2, ",").collect();
+            let location_parts: Vec<&str> = location_parts[1].splitn(2, ',').collect();
 
             if location_parts.len() != 2 {
                 trace!("Location does not have 2 parts splitting on ,: {}", line);
                 continue;
             }
 
             let line = location_parts[0].parse::<i32>()?;
-            let column = location_parts[1].replace(")", "").parse::<i32>()?;
+            let column = location_parts[1].replace(')', "").parse::<i32>()?;
 
-            let check_parts: Vec<&str> = check_string.splitn(2, " ").collect();
+            let check_parts: Vec<&str> = check_string.splitn(2, ' ').collect();
             if check_parts.len() != 2 {
                 trace!("Check does not have 2 parts splitting on ' ': {}", line);
                 continue;

qlty-check/src/planner/config.rs

@@ -69,7 +69,7 @@ fn configure_plugins(planner: &Planner) -> Result<Vec<ActivePlugin>> {
         }
 
         let name = &enabled_plugin.name;
-        let plugin = configure_plugin(planner, name, &enabled_plugin)?;
+        let plugin = configure_plugin(planner, name, enabled_plugin)?;
         enabled_plugins.push(ActivePlugin {
             name: name.to_string(),
             plugin,
@@ -181,7 +181,7 @@ fn configure_plugin(
             }
         }
 
-        Ok(plugin_def.into())
+        Ok(plugin_def)
     } else {
         bail!("Unknown plugin {}", name)
     }

qlty-check/src/planner/config_files.rs

@@ -70,7 +70,7 @@ pub fn ignore_globset(ignore: &Vec<Ignore>) -> Result<GlobSet> {
 }
 
 pub fn plugin_configs(planner: &Planner) -> Result<HashMap<String, Vec<PluginConfigFile>>> {
-    let plugins = enabled_plugins(&planner)?;
+    let plugins = enabled_plugins(planner)?;
     let mut plugins_configs = vec![];
 
     for active_plugin in &plugins {