-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert fleetcontroller to controller-runtime #2018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
force-pushed
the
convert-fleetcontroller-controller-runtime
branch
5 times, most recently
from
December 19, 2023 08:43
fd9194b
to
3e9c663
Compare
manno
force-pushed
the
convert-fleetcontroller-controller-runtime
branch
from
December 19, 2023 14:55
9352516
to
3a18e63
Compare
weyfonk
reviewed
Dec 20, 2023
Use the same approach to command line arg parsing and zap logger, kubeconfig in agent and fleetcontroller * use zap zopts Flags * put logger in context * add debug switch to register/clusterstatus
manno
force-pushed
the
convert-fleetcontroller-controller-runtime
branch
2 times, most recently
from
December 20, 2023 20:16
09a8595
to
62c0067
Compare
manno
changed the title
Convert fleetcontroller controller runtime
Convert fleetcontroller to controller-runtime
Dec 21, 2023
* affects targeting and gitrepo controllers: * bundle controller * gitrepo controller * display controller * imagescan * added imagescan scheduler based on quartz module * split code in target pkg into separate files * purge bundledeployments from gitrepo controller, no more cross-namespace owner references from apply * bundle reconciler deletes bundle deployments if bundle is not found * gitrepo reconciler reports errors in status * move cluster status update code from agentmanagement to cluster reconciler * updated unit and integrationtests * configurable bind addresses for health and metrics * rename c-r manager setup files to operator.go
manno
force-pushed
the
convert-fleetcontroller-controller-runtime
branch
from
December 21, 2023 15:39
62c0067
to
03b2f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #1972