Docs: warm about password sharing links with the same password #11525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Aug 7, 2024
Comment on lines
+74
to
+75
| If you generate multiple sharing links using the same password for a project, | ||
| only the first link will work. |
There was a problem hiding this comment.
Can we check against this when we do the hashing, or will they hash differently because of the salt?
There was a problem hiding this comment.
We can check, but we will need to check each hashed password, which will be slow if users have lots of passwords, hopefully it's more fast with the new hash algo we are going to implement. So, we could have that feature.
There was a problem hiding this comment.
The form is now able to check for dups with https://github.com/readthedocs/readthedocs-corporate/pull/1849, should we still mention this warning?
There was a problem hiding this comment.
I think we should be fine closing this, if the form can check for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation previews 📚
docs): https://docs--11525.org.readthedocs.build/en/11525/dev): https://dev--11525.org.readthedocs.build/en/11525/