Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: warm about password sharing links with the same password #11525

Closed
wants to merge 1 commit into from
Closed

Docs: warm about password sharing links with the same password #11525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/user/commercial/sharing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ view your project.
This is useful for when you have documentation you want users to bookmark.
They can enter a URL directly and enter the password when prompted.

.. warning::

Since multiple passwords can be created for a single project,
each password must be unique within that project.
If you generate multiple sharing links using the same password for a project,
only the first link will work.
Comment on lines +74 to +75
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check against this when we do the hashing, or will they hash differently because of the salt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check, but we will need to check each hashed password, which will be slow if users have lots of passwords, hopefully it's more fast with the new hash algo we are going to implement. So, we could have that feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The form is now able to check for dups with https://github.com/readthedocs/readthedocs-corporate/pull/1849, should we still mention this warning?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be fine closing this, if the form can check for it.


HTTP Authorization Header
*************************

Expand Down
Loading