-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unique name for events and doctype parameter alone is redundant #2903
Merged
mergify
merged 5 commits into
resilient-tech:develop
from
Ninad1306:publish_realtime_fix
Jan 8, 2025
Merged
fix: unique name for events and doctype parameter alone is redundant #2903
mergify
merged 5 commits into
resilient-tech:develop
from
Ninad1306:publish_realtime_fix
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2903 +/- ##
===========================================
- Coverage 60.15% 59.97% -0.18%
===========================================
Files 122 122
Lines 12063 12118 +55
===========================================
+ Hits 7256 7268 +12
- Misses 4807 4850 +43
|
ljain112
reviewed
Dec 25, 2024
india_compliance/gst_india/doctype/gst_return_log/gst_return_log.py
Outdated
Show resolved
Hide resolved
vorasmit
previously approved these changes
Jan 8, 2025
vorasmit
approved these changes
Jan 8, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
…2903) <sub><a href="https://huly.app/guest/resilienttech?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJsaW5rSWQiOiI2NzY5NTQ2YWYxNDRmNTg1YWU0ZjQ0MzciLCJndWVzdCI6InRydWUiLCJlbWFpbCI6IiNndWVzdEBoYy5lbmdpbmVlcmluZyIsIndvcmtzcGFjZSI6Inctc21pdHZvcmEyMDMtcmVzaWxpZW50dGVjLTY2N2U0MjkxLWEwNWMwNjY4N2EtNjM4MjY3In0.rQ77T2lxpZdRqwFHPyoHa18VMzo4Qv2xyzoj9Jlr6fw">Huly®: <b>IC-3030</b></a></sub> (cherry picked from commit dc0be5d) # Conflicts: # india_compliance/gst_india/doctype/gst_return_log/gst_return_log.py # india_compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.js
mergify bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
…2903) <sub><a href="https://huly.app/guest/resilienttech?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJsaW5rSWQiOiI2NzY5NTQ2YWYxNDRmNTg1YWU0ZjQ0MzciLCJndWVzdCI6InRydWUiLCJlbWFpbCI6IiNndWVzdEBoYy5lbmdpbmVlcmluZyIsIndvcmtzcGFjZSI6Inctc21pdHZvcmEyMDMtcmVzaWxpZW50dGVjLTY2N2U0MjkxLWEwNWMwNjY4N2EtNjM4MjY3In0.rQ77T2lxpZdRqwFHPyoHa18VMzo4Qv2xyzoj9Jlr6fw">Huly®: <b>IC-3030</b></a></sub> (cherry picked from commit dc0be5d)
This was referenced Jan 8, 2025
mergify bot
added a commit
that referenced
this pull request
Jan 8, 2025
…tfix/pr-2903 fix: unique name for events and doctype parameter alone is redundant (backport #2903)
mergify bot
added a commit
that referenced
this pull request
Jan 8, 2025
…tfix/pr-2903 fix: unique name for events and doctype parameter alone is redundant (backport #2903)
india-compliance-bot
added a commit
that referenced
this pull request
Jan 15, 2025
# [15.15.0](v15.14.7...v15.15.0) (2025-01-15) ### Bug Fixes * `ignore_permissions` when handeling missing gstr2a 2b transactions ([a2c2fda](a2c2fda)) * do not migrate old passwords if decryption fails ([f5f093c](f5f093c)) * enqueue only once for transactions created in bulk ([3faba43](3faba43)) * **gstr-1:** handle gov api error when downloading and make it optional for unfiled returns ([#2897](#2897)) ([744fedc](744fedc)) * ignore permissions for saving gstin doc ([133405c](133405c)) * only download sections with records ([924046e](924046e)) * primary action to reset on change of `is_nil` if already uploaded info ([225f681](225f681)) * round gst values before upload for accurate comparision with govt summary ([57252b8](57252b8)) * save nil filing information in gst return log ([c6c4352](c6c4352)) * selective download supported only for filled information, fixes related to updating description ([ea9feaa](ea9feaa)) * selectively download sections in GSTR-1 based on summary information ([abf6f02](abf6f02)) * set recon status for unlinked document ([7db22c8](7db22c8)) * suggest default return period correct when in first period ([1773cff](1773cff)) * support purchases from tax collector in purchae reco tool ([4ea05f6](4ea05f6)) * trim OTP values before sending ([7e33fa7](7e33fa7)) * unique name for events and doctype parameter alone is redundant ([#2903](#2903)) ([7d47599](7d47599)) ### Features * allow filing of Nil return for GSTR-1 ([#2906](#2906)) ([5a05376](5a05376)), closes [#2880](#2880)
india-compliance-bot
added a commit
that referenced
this pull request
Jan 15, 2025
## [14.30.14](v14.30.13...v14.30.14) (2025-01-15) ### Bug Fixes * `ignore_permissions` when handeling missing gstr2a 2b transactions ([d0e1c50](d0e1c50)) * do not migrate old passwords if decryption fails ([ce56047](ce56047)) * enqueue only once for transactions created in bulk ([3330dfc](3330dfc)) * only download sections with records ([6249f05](6249f05)) * save nil filing information in gst return log ([5c96a4c](5c96a4c)) * selective download supported only for filled information, fixes related to updating description ([f915797](f915797)) * selectively download sections in GSTR-1 based on summary information ([1ccea3f](1ccea3f)) * set recon status for unlinked document ([f567fc1](f567fc1)) * suggest default return period correct when in first period ([eed3648](eed3648)) * support purchases from tax collector in purchae reco tool ([e4108a4](e4108a4)) * unique name for events and doctype parameter alone is redundant ([#2903](#2903)) ([0a94bb9](0a94bb9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.