Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unique name for events and doctype parameter alone is redundant #2903

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Dec 23, 2024

No description provided.

@Ninad1306 Ninad1306 requested a review from ljain112 December 23, 2024 12:17
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.97%. Comparing base (5f227b2) to head (51cfa46).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 25.00% 3 Missing ⚠️
...econciliation_tool/purchase_reconciliation_tool.py 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2903      +/-   ##
===========================================
- Coverage    60.15%   59.97%   -0.18%     
===========================================
  Files          122      122              
  Lines        12063    12118      +55     
===========================================
+ Hits          7256     7268      +12     
- Misses        4807     4850      +43     
Files with missing lines Coverage Δ
...gst_india/doctype/gst_return_log/gst_return_log.py 25.15% <100.00%> (-0.32%) ⬇️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% <ø> (ø)
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 22.64% <ø> (ø)
india_compliance/gst_india/utils/gstr_2/gstr.py 89.55% <ø> (ø)
...econciliation_tool/purchase_reconciliation_tool.py 24.58% <33.33%> (+0.12%) ⬆️
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 62.01% <25.00%> (ø)

... and 12 files with indirect coverage changes

Impacted file tree graph

@Ninad1306 Ninad1306 requested a review from ljain112 December 26, 2024 09:29
@ljain112 ljain112 self-assigned this Dec 26, 2024
@ljain112 ljain112 added the p1 label Dec 26, 2024
vorasmit
vorasmit previously approved these changes Jan 8, 2025
@mergify mergify bot merged commit dc0be5d into resilient-tech:develop Jan 8, 2025
11 checks passed
mergify bot pushed a commit that referenced this pull request Jan 8, 2025
mergify bot added a commit that referenced this pull request Jan 8, 2025
…tfix/pr-2903

fix: unique name for events and doctype parameter alone is redundant (backport #2903)
mergify bot added a commit that referenced this pull request Jan 8, 2025
…tfix/pr-2903

fix: unique name for events and doctype parameter alone is redundant (backport #2903)
india-compliance-bot added a commit that referenced this pull request Jan 15, 2025
# [15.15.0](v15.14.7...v15.15.0) (2025-01-15)

### Bug Fixes

* `ignore_permissions` when handeling missing gstr2a 2b transactions ([a2c2fda](a2c2fda))
* do not migrate old passwords if decryption fails ([f5f093c](f5f093c))
* enqueue only once for transactions created in bulk ([3faba43](3faba43))
* **gstr-1:** handle gov api error when downloading and make it optional for unfiled returns ([#2897](#2897)) ([744fedc](744fedc))
* ignore permissions for saving gstin doc ([133405c](133405c))
* only download sections with records ([924046e](924046e))
* primary action to reset on change of `is_nil` if already uploaded info ([225f681](225f681))
* round gst values before upload for accurate comparision with govt summary ([57252b8](57252b8))
* save nil filing information in gst return log ([c6c4352](c6c4352))
* selective download supported only for filled information, fixes related to updating description ([ea9feaa](ea9feaa))
* selectively download sections in GSTR-1 based on summary information ([abf6f02](abf6f02))
* set recon status for unlinked document ([7db22c8](7db22c8))
* suggest default return period correct when in first period ([1773cff](1773cff))
* support purchases from tax collector in purchae reco tool ([4ea05f6](4ea05f6))
* trim OTP values before sending ([7e33fa7](7e33fa7))
* unique name for events and doctype parameter alone is redundant ([#2903](#2903)) ([7d47599](7d47599))

### Features

* allow filing of Nil return for GSTR-1 ([#2906](#2906)) ([5a05376](5a05376)), closes [#2880](#2880)
india-compliance-bot added a commit that referenced this pull request Jan 15, 2025
## [14.30.14](v14.30.13...v14.30.14) (2025-01-15)

### Bug Fixes

* `ignore_permissions` when handeling missing gstr2a 2b transactions ([d0e1c50](d0e1c50))
* do not migrate old passwords if decryption fails ([ce56047](ce56047))
* enqueue only once for transactions created in bulk ([3330dfc](3330dfc))
* only download sections with records ([6249f05](6249f05))
* save nil filing information in gst return log ([5c96a4c](5c96a4c))
* selective download supported only for filled information, fixes related to updating description ([f915797](f915797))
* selectively download sections in GSTR-1 based on summary information ([1ccea3f](1ccea3f))
* set recon status for unlinked document ([f567fc1](f567fc1))
* suggest default return period correct when in first period ([eed3648](eed3648))
* support purchases from tax collector in purchae reco tool ([e4108a4](e4108a4))
* unique name for events and doctype parameter alone is redundant ([#2903](#2903)) ([0a94bb9](0a94bb9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants