Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectively download sections in GSTR-1 based on summary information #2938

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

vorasmit
Copy link
Member

@vorasmit vorasmit commented Jan 8, 2025

Reduces Number of API calls.

  • Handle Nil Return
  • Handle Sections with zero values

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 59.92%. Comparing base (9d1d63f) to head (a197267).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 17.64% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2938      +/-   ##
===========================================
- Coverage    59.97%   59.92%   -0.06%     
===========================================
  Files          122      122              
  Lines        12117    12131      +14     
===========================================
+ Hits          7267     7269       +2     
- Misses        4850     4862      +12     
Files with missing lines Coverage Δ
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 19.69% <17.64%> (-2.95%) ⬇️

... and 5 files with indirect coverage changes

Impacted file tree graph

@vorasmit vorasmit marked this pull request as draft January 8, 2025 08:37
@vorasmit vorasmit marked this pull request as ready for review January 10, 2025 06:46
@vorasmit vorasmit merged commit 41c86be into resilient-tech:develop Jan 10, 2025
13 checks passed
mergify bot added a commit that referenced this pull request Jan 10, 2025
…tfix/pr-2938

fix: selectively download sections in GSTR-1 based on summary information (backport #2938)
mergify bot added a commit that referenced this pull request Jan 10, 2025
…tfix/pr-2938

fix: selectively download sections in GSTR-1 based on summary information (backport #2938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant