Menu::make method and public getItems for faster prototyping menus and micro menus rendering. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate render operation in two methods: make and render
Allow public getter to be able to iterate items outside a presentable (using Menu::make)
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| */ | ||
| public function render(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?string | ||
| public function make(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?MenuGenerator |
There was a problem hiding this comment.
Avoid unused parameters such as '$presenter'.
| */ | ||
| public function render(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?string | ||
| public function make(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?MenuGenerator |
There was a problem hiding this comment.
Avoid unused parameters such as '$specialSidebar'.
StyleCI fixes
StyleCI fixes
code coverage fixes
codestyle fixes
codestyle fixes
codestyle fixes
codestyleci fixes
codestyle fixes
|
Code Climate has analyzed commit e487742 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
I don't know how to fix codeclimate issues, any clue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rinvex Menus features are solid: multiple menus, item attributes and properties, nesting and dropdowns, and presenters.
People gets very creative about menus.
In our case we are prototyping menus for a new app and coding presentables is not the right moment yet.
We are using tabler, a derivative from bootstrap 5 with some twists so we cannot use default ones even if blade templates were made for BS5. They are currently made for BS4.
Apart from that we are using TwigBridge.
With this pull developers can make: