-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu::make method and public getItems for faster prototyping menus and micro menus rendering. #109
Open
n3storm
wants to merge
10
commits into
rinvex:master
Choose a base branch
from
n3storm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
82a0327
Update MenuManager.php
n3storm 5ee7812
Update MenuGenerator.php
n3storm 69890dc
Update MenuManager.php
n3storm f268eb4
Update MenuGenerator.php
n3storm b0c2c84
Update MenuManager.php
n3storm 853308b
Update MenuManager.php
n3storm 41c3196
Update MenuManager.php
n3storm efd2904
Update MenuManager.php
n3storm 48cb8e9
Update MenuManager.php
n3storm e487742
Update MenuManager.php
n3storm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,16 +110,16 @@ public function register($name, Closure $callback): void | |
} | ||
|
||
/** | ||
* Render the menu tag by given name. | ||
* Initializes the menu tag by given name without rendering. | ||
* | ||
* @param string $name | ||
* @param string $presenter | ||
* @param array $bindings | ||
* @param bool $specialSidebar | ||
* @param string $name | ||
* @param string|null $presenter | ||
* @param array $bindings | ||
* @param bool $specialSidebar | ||
* | ||
* @return string|null | ||
* @return MenuGenerator|null | ||
*/ | ||
public function render(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?string | ||
public function make(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?MenuGenerator | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid unused parameters such as '$specialSidebar'. |
||
{ | ||
if ($this->has($name)) { | ||
$instance = $this->instance($name); | ||
|
@@ -137,7 +137,29 @@ public function render(string $name, string $presenter = null, array $bindings = | |
$params ? $callback($instance, ...$params) : $callback($instance); | ||
}); | ||
|
||
return $instance->setBindings($bindings)->render($presenter, $specialSidebar); | ||
return $instance->setBindings($bindings); | ||
} | ||
|
||
return null; | ||
} | ||
|
||
/** | ||
* Render the menu tag by given name. | ||
* | ||
* @param string $name | ||
* @param string|null $presenter | ||
* @param array $bindings | ||
* @param bool $specialSidebar | ||
* | ||
* @return string|null | ||
*/ | ||
public function render(string $name, string $presenter = null, array $bindings = [], bool $specialSidebar = false): ?string | ||
{ | ||
if ($this->has($name)) { | ||
$instance = $this->make($name, $presenter, $bindings, $specialSidebar); | ||
if ($instance) { | ||
return $instance->render($presenter, $specialSidebar); | ||
} | ||
} | ||
|
||
return null; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid unused parameters such as '$presenter'.