Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gid_hash_ from AttachmentData #416

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

fuzzypixelz
Copy link
Contributor

This member is computed in the constructor which is in turn called in rmw_publish. This hash is not serialized as part of the attachment.

I noticed this when profiling the multi-process iRobot benchmark, where hash_gid was taking around 23% of the running time of rmw_publish.

This member is computed in the constructor which is in turn called
in `rmw_publish`. This hash is not serialized as part of the attachment.
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the usual CI tests and no regressions.

@Yadunund Yadunund merged commit f040f5c into ros2:rolling Jan 13, 2025
5 checks passed
@Yadunund
Copy link
Member

@Mergifyio backport jazzy humble

Copy link

mergify bot commented Jan 13, 2025

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 13, 2025
This member is computed in the constructor which is in turn called
in `rmw_publish`. This hash is not serialized as part of the attachment.

(cherry picked from commit f040f5c)
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
This member is computed in the constructor which is in turn called
in `rmw_publish`. This hash is not serialized as part of the attachment.

(cherry picked from commit f040f5c)

# Conflicts:
#	rmw_zenoh_cpp/src/detail/attachment_helpers.cpp
#	rmw_zenoh_cpp/src/detail/attachment_helpers.hpp
Yadunund pushed a commit that referenced this pull request Jan 13, 2025
This member is computed in the constructor which is in turn called
in `rmw_publish`. This hash is not serialized as part of the attachment.

(cherry picked from commit f040f5c)

Co-authored-by: Mahmoud Mazouz <[email protected]>
ahcorde added a commit that referenced this pull request Jan 14, 2025
* Remove `gid_hash_` from `AttachmentData` (#416)

This member is computed in the constructor which is in turn called
in `rmw_publish`. This hash is not serialized as part of the attachment.

(cherry picked from commit f040f5c)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants