Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #3366 didn't work, revert it and fix the right way #3384

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

brad-linden
Copy link
Collaborator

Revert "attempt to get the tag-release.yaml workflow to actually succeed at triggering a release build (#3366)"

This reverts commit 3b79d2c.

will be proceeding with provisioning a new token to try to fix this the right way:
https://stackoverflow.com/a/71372524

…eed at triggering a release build (#3366)"

This reverts commit 3b79d2c.
Copy link
Collaborator

@nat-goodspeed nat-goodspeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it doesn't work, I approve this revert.

But I'm surprised that GITHUB_TOKEN doesn't do everything a Personal Access Token would.

@brad-linden
Copy link
Collaborator Author

Since it doesn't work, I approve this revert.

But I'm surprised that GITHUB_TOKEN doesn't do everything a Personal Access Token would.

yeah the devil is in the details here in the GH docs, apparently it is intended as a protection against accidentally creating mutually recursive workflows
https://stackoverflow.com/a/71372524
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#triggering-a-workflow-from-a-workflow

@brad-linden brad-linden changed the title PR #3366 didn't work, revert it. PR #3366 didn't work, revert it and fix the right way Jan 9, 2025
# required so that the results of this tag creation can trigger the build workflow
# https://stackoverflow.com/a/71372524
# https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow
# this token will need to be renewed anually in January
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you store a companion secret encoding the upcoming expiration date of LL_TAG_RELEASE_TOKEN and, once it gets close, start emitting a warning message on the GH workflow page. You don't need to use the extra ::warning ... syntax; it works to code:
echo "::warning::LL_TAG_RELEASE_TOKEN must be recreated before $expiration"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capturead as #3386

@brad-linden brad-linden merged commit 95afff0 into develop Jan 9, 2025
14 checks passed
@brad-linden brad-linden deleted the brad/develop branch January 9, 2025 23:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants