Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #3366 didn't work, revert it and fix the right way #3384

Merged
merged 2 commits into from
Jan 9, 2025
Merged

PR #3366 didn't work, revert it and fix the right way #3384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70be1e1
Revert "attempt to get the tag-release.yaml workflow to actually succ…
brad-linden Jan 9, 2025
583b6ee
Another attempt to fix nightly develop builds (hopefully the right wa…
brad-linden Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:
push:
branches: ["main", "release/*", "project/*"]
tags: ["Second_Life*"]
workflow_run:
workflows: ["Tag a Build"]
types:
- completed

jobs:
# The whole point of the setup job is that we want to set variables once
Expand All @@ -29,7 +25,7 @@ jobs:
# When you want to use a string variable as a workflow YAML boolean, it's
# important to ensure it's the empty string when false. If you omit || '',
# its value when false is "false", which is interpreted as true.
RELEASE_RUN: ${{ (github.event.inputs.release_run || github.event_name == 'workflow_run' || github.ref_type == 'tag' && startsWith(github.ref_name, 'Second_Life')) && 'Y' || '' }}
RELEASE_RUN: ${{ (github.event.inputs.release_run || github.ref_type == 'tag' && startsWith(github.ref_name, 'Second_Life')) && 'Y' || '' }}
FROM_FORK: ${{ github.event.pull_request.head.repo.fork }}
steps:
- name: Set Variables
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/tag-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ jobs:
- name: Update Tag
uses: actions/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
# use a real access token instead of GITHUB_TOKEN default.
# required so that the results of this tag creation can trigger the build workflow
# https://stackoverflow.com/a/71372524
# https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow
# this token will need to be renewed anually in January
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you store a companion secret encoding the upcoming expiration date of LL_TAG_RELEASE_TOKEN and, once it gets close, start emitting a warning message on the GH workflow page. You don't need to use the extra ::warning ... syntax; it works to code:
echo "::warning::LL_TAG_RELEASE_TOKEN must be recreated before $expiration"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capturead as #3386

github-token: ${{ secrets.LL_TAG_RELEASE_TOKEN }}
script: |
github.rest.git.createRef({
owner: context.repo.owner,
Expand Down
Loading