Upgrade go-sqlite3 to v1.14.23 #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muralikoppolu
approved these changes
Feb 15, 2024
|
You need to update the description to say "testing not required" or whatever. LGTM once you update with latest go-sqlite3 master. |
kevinburkesegment
approved these changes
Feb 16, 2024
|
Replaced this one with: PR #142 |
erikdw
added a commit
that referenced
this pull request
Feb 16, 2024
## Description Update the `go-sqlite3` dependency for Ctlstore to get to the latest upstream version from https://github.com/mattn/go-sqlite3. Notably we depend on a Segment-specific fork that includes a patch which enables preupdate hooks for our code without requiring a build-time flag to be manually put into place by all users of the ctlstore library. ## Details This depends on segmentio/go-sqlite3#9 to allow the `go get` to succeed. Once that is merged, we deleted the [segment-v1.14.22](https://github.com/segmentio/go-sqlite3/releases/tag/segment-v1.14.22) tag in that repo and recreated it as [v1.14.22-segment](https://github.com/segmentio/go-sqlite3/releases/tag/v1.14.22-segment). > [!TIP] > Despite fixing the `master` of go-sqlite3 to [update module path](https://github.com/segmentio/go-sqlite3/blob/b9c49a6eaf4ca03f2515c9ef9334d20741363b3b/go.mod#L1), I was getting errors doing `go get` after deleting and recreating the `segment-v1.14.22` tag like so: > ``` > % go get github.com/segmentio/[email protected] > go: github.com/segmentio/[email protected] (v1.14.23-0.20240208202956-73b5bef61db6) > requires github.com/segmentio/[email protected]: parsing go.mod: > module declares its path as: github.com/mattn/go-sqlite3 > but was required as: github.com/segmentio/go-sqlite3 > ``` > > @kevinburkesegment explained this was likely due to the Go package cache, so we decided to just delete that previous tag and not try to recreate it. Instead we created a tag with a different name. Testing completed successfully: * [x] ensure CI runs * [x] verify on other services that include ctlstore client, when those services are updated. https://segment.atlassian.net/browse/IO-1695 > [!NOTE] > Replacement for PR #140 which had the wrong version number in its branch name.
zhou-hongyu
pushed a commit
that referenced
this pull request
Feb 20, 2024
## Description Update the `go-sqlite3` dependency for Ctlstore to get to the latest upstream version from https://github.com/mattn/go-sqlite3. Notably we depend on a Segment-specific fork that includes a patch which enables preupdate hooks for our code without requiring a build-time flag to be manually put into place by all users of the ctlstore library. ## Details This depends on segmentio/go-sqlite3#9 to allow the `go get` to succeed. Once that is merged, we deleted the [segment-v1.14.22](https://github.com/segmentio/go-sqlite3/releases/tag/segment-v1.14.22) tag in that repo and recreated it as [v1.14.22-segment](https://github.com/segmentio/go-sqlite3/releases/tag/v1.14.22-segment). > [!TIP] > Despite fixing the `master` of go-sqlite3 to [update module path](https://github.com/segmentio/go-sqlite3/blob/b9c49a6eaf4ca03f2515c9ef9334d20741363b3b/go.mod#L1), I was getting errors doing `go get` after deleting and recreating the `segment-v1.14.22` tag like so: > ``` > % go get github.com/segmentio/[email protected] > go: github.com/segmentio/[email protected] (v1.14.23-0.20240208202956-73b5bef61db6) > requires github.com/segmentio/[email protected]: parsing go.mod: > module declares its path as: github.com/mattn/go-sqlite3 > but was required as: github.com/segmentio/go-sqlite3 > ``` > > @kevinburkesegment explained this was likely due to the Go package cache, so we decided to just delete that previous tag and not try to recreate it. Instead we created a tag with a different name. Testing completed successfully: * [x] ensure CI runs * [x] verify on other services that include ctlstore client, when those services are updated. https://segment.atlassian.net/browse/IO-1695 > [!NOTE] > Replacement for PR #140 which had the wrong version number in its branch name.
erikdw
added a commit
that referenced
this pull request
Feb 27, 2024
…s (families, tables) (#141) * Upgrade go-sqlite3 to v1.14.22 (#142) ## Description Update the `go-sqlite3` dependency for Ctlstore to get to the latest upstream version from https://github.com/mattn/go-sqlite3. Notably we depend on a Segment-specific fork that includes a patch which enables preupdate hooks for our code without requiring a build-time flag to be manually put into place by all users of the ctlstore library. ## Details This depends on segmentio/go-sqlite3#9 to allow the `go get` to succeed. Once that is merged, we deleted the [segment-v1.14.22](https://github.com/segmentio/go-sqlite3/releases/tag/segment-v1.14.22) tag in that repo and recreated it as [v1.14.22-segment](https://github.com/segmentio/go-sqlite3/releases/tag/v1.14.22-segment). > [!TIP] > Despite fixing the `master` of go-sqlite3 to [update module path](https://github.com/segmentio/go-sqlite3/blob/b9c49a6eaf4ca03f2515c9ef9334d20741363b3b/go.mod#L1), I was getting errors doing `go get` after deleting and recreating the `segment-v1.14.22` tag like so: > ``` > % go get github.com/segmentio/[email protected] > go: github.com/segmentio/[email protected] (v1.14.23-0.20240208202956-73b5bef61db6) > requires github.com/segmentio/[email protected]: parsing go.mod: > module declares its path as: github.com/mattn/go-sqlite3 > but was required as: github.com/segmentio/go-sqlite3 > ``` > > @kevinburkesegment explained this was likely due to the Go package cache, so we decided to just delete that previous tag and not try to recreate it. Instead we created a tag with a different name. Testing completed successfully: * [x] ensure CI runs * [x] verify on other services that include ctlstore client, when those services are updated. https://segment.atlassian.net/browse/IO-1695 > [!NOTE] > Replacement for PR #140 which had the wrong version number in its branch name. * first pass of adding family name and table name to reflector side * query statement filters by family name * add UTs to cover DML entries filtering by family * Fix UTs * query statement filters by table name * Add comprehensive UTs * query should be able to filter by whole family and cherry pickable tables --------- Co-authored-by: Erik Weathers <[email protected]> Co-authored-by: Hongyu Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on segmentio/go-sqlite3#9
Once that is merged, recreate the segment-v1.14.22 tag in that repo.
Testing completed successfully: ensure CI runs, verify on other services that include ctlstore, when those services are updated. https://segment.atlassian.net/browse/IO-1695