Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused filter processor #5805

Merged
merged 1 commit into from
Jan 15, 2025
Merged

remove unused filter processor #5805

merged 1 commit into from
Jan 15, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 15, 2025

Description:
Fixes #5702

@atoulme atoulme requested review from a team as code owners January 15, 2025 03:43
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon my ignorance, but is the Fargate deployment an artifact released separately from the regular release cycle, or is it simply a configured collector? I realize this is functionally a no-op but users may be thrown off by the change to documentation without some kind of changelog entry. (If there's no separate release for Fargate, we can add the changelog notes now in the regular release notes CHANGELOG.)

@atoulme
Copy link
Contributor Author

atoulme commented Jan 15, 2025

It's shipped in our Dockerfile and the instructions don't work and are misleading right now, hence the original bug report. I think removing this removes confusion.

@atoulme atoulme merged commit dfd7d05 into main Jan 15, 2025
278 checks passed
@atoulme atoulme deleted the remove_processor branch January 15, 2025 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter processor in fargate config is not used in any pipeline
2 participants