Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused filter processor #5805

Merged
merged 1 commit into from
Jan 15, 2025
Merged

remove unused filter processor #5805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions cmd/otelcol/config/collector/fargate_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
# This collector config file is designed for use within an ECS task.
# The collector should run in a sidecar container within an ECS task.
config_sources:
env:
defaults:
METRICS_TO_EXCLUDE: []

extensions:
health_check:
endpoint: 0.0.0.0:13133
Expand Down Expand Up @@ -73,14 +68,6 @@ processors:
resourcedetection:
detectors: [ecs]
override: false
# Enables the filter processor with example settings
# Full configuration here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/filterprocessor
# NOTE: These settings need to be change when using this processor
filter/1:
metrics:
exclude:
match_type: regexp
metric_names: ${env:METRICS_TO_EXCLUDE}
# Optional: The following processor can be used to add a default "deployment.environment" attribute to the logs and
# traces when it's not populated by instrumentation libraries.
# If enabled, make sure to enable this processor in the pipeline below.
Expand Down
14 changes: 1 addition & 13 deletions cmd/otelcol/fips/config/fargate_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
# This collector config file is designed for use within an ECS task.
# The collector should run in a sidecar container within an ECS task.
config_sources:
env:
defaults:
METRICS_TO_EXCLUDE: []

extensions:
health_check:
endpoint: 0.0.0.0:13133
Expand Down Expand Up @@ -70,14 +65,7 @@ processors:
resourcedetection:
detectors: [ecs]
override: false
# Enables the filter processor with example settings
# Full configuration here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/filterprocessor
# NOTE: These settings need to be change when using this processor
filter/1:
metrics:
exclude:
match_type: regexp
metric_names: ${env:METRICS_TO_EXCLUDE}

# Optional: The following processor can be used to add a default "deployment.environment" attribute to the logs and
# traces when it's not populated by instrumentation libraries.
# If enabled, make sure to enable this processor in the pipeline below.
Expand Down
3 changes: 1 addition & 2 deletions deployments/fargate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ In summary, the default Collector container definition does the following:
- Sets the realm using environment variable `SPLUNK_REALM`.
- Sets the default configuration file path using environment variable `SPLUNK_CONFIG`.

Assign a stringified array of metrics you want excluded to environment variable
`METRICS_TO_EXCLUDE`. You can set the memory limit for the memory limiter processor using
You can set the memory limit for the memory limiter processor using
environment variable `SPLUNK_MEMORY_LIMIT_MIB`. The default memory limit is 512 MiB. For
more information about the memory limiter processor, see
[here](https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/README.md)
Expand Down
Loading