Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1878222 bump node-http-handler to next major, v4 #992

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

sfc-gh-dszmolka
Copy link
Collaborator

@sfc-gh-dszmolka sfc-gh-dszmolka commented Jan 10, 2025

Description

  • @aws-sdk/client-s3 - the current dependency specification anyways installs latest 3.726.0 already, but since already changing package.json, i figured I can note this too
  • @smithy/node-http-handler - we currently install latest v3 , 3.3.3. They released a new major version because they dropped support for node:16 (reference: https://github.com/smithy-lang/smithy-typescript/releases/tag/%40smithy%2Fnode-http-handler%404.0.0) and we already dropped support for node:16 in snowflake-sdk earlier.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (3ab8b63) to head (4859c72).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   88.97%   88.96%   -0.02%     
==========================================
  Files          72       72              
  Lines        6985     6985              
==========================================
- Hits         6215     6214       -1     
- Misses        770      771       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka enabled auto-merge (squash) January 13, 2025 09:46
@sfc-gh-dszmolka sfc-gh-dszmolka requested review from a team and sfc-gh-pbulawa January 13, 2025 14:02
@sfc-gh-dszmolka sfc-gh-dszmolka merged commit 562de22 into master Jan 16, 2025
46 of 47 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-1878222-bump-node-http-handler branch January 16, 2025 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants