-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_mempool): rename to tx_from_address_exists to better reflect implementaion #3173
chore(starknet_mempool): rename to tx_from_address_exists to better reflect implementaion #3173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ayeletstarkware and @Yael-Starkware)
a discussion (no related file):
+reviewer:@Yael-Starkware
+reviewer:@ayeletstarkware
9e1dfdb
to
1e2c1af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)
crates/starknet_mempool/src/communication.rs
line 105 at r2 (raw file):
pub(crate) fn has_tx_from_address( &self, _contract_address: ContractAddress,
why?
Code quote:
contract_address
Previously, ayeletstarkware (Ayelet Zilber) wrote…
now |
1e2c1af
to
815979b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
Previously, ArniStarkware (Arnon Hod) wrote…
+reviewer:@alonh5 |
50044e1
to
c3f2719
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
…ect implementaion
c3f2719
to
d10f836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions
crates/starknet_mempool_types/src/communication.rs
line 49 at r3 (raw file):
async fn commit_block(&self, args: CommitBlockArgs) -> MempoolClientResult<()>; async fn get_txs(&self, n_txs: usize) -> MempoolClientResult<Vec<AccountTransaction>>; async fn has_tx_from_address(
The signature of the function includes the arguments, so sometimes, we can avoid redundancy.
Suggestion:
contains_tx_from
crates/starknet_mempool_types/src/communication.rs
line 51 at r3 (raw file):
async fn has_tx_from_address( &self, contract_address: ContractAddress,
It's still an account address though, no?
Suggestion:
account_address
crates/starknet_mempool_types/src/communication.rs
line 111 at r3 (raw file):
contract_address: ContractAddress, ) -> MempoolClientResult<bool> { let request = MempoolRequest::DeployAccountExists(contract_address);
Match everywhere to new naming.
Code quote:
DeployAccountExists
Previously, alonh5 (Alon Haramati) wrote…
Done. See #3298. |
Previously, alonh5 (Alon Haramati) wrote…
Done. See #3298. |
Previously, alonh5 (Alon Haramati) wrote…
Done. See #3298. |
Previously, ArniStarkware (Arnon Hod) wrote…
|
No description provided.