feat(starknet_gateway): use has tx from address to skip validate

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(starknet_gateway): use has tx from address to skip validate #3218 👈 (View in Graphite)
• chore(starknet_gateway): remove spawn blocking for process tx flow #3253
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yael-Starkware]

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @ArniStarkware)

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 138 at r1 (raw file):

                    // not find it?
                    return false;
                }

I think we should return the error, as any other error.

Code quote:

                Err(MempoolClientError::ClientError(_err)) => {
                    warn!("A client error occurred");
                    // Should we simply take a strict approach and in this case say the mempool did
                    // not find it?
                    return false;
                }

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 141 at r1 (raw file):

                Err(MempoolClientError::MempoolError(_err)) => {
                    panic!("No such error can occur on 'has_tx_from_address'")
                }

not sure I'd assert it, since the mempool implementation can change over time.

Code quote:

                Err(MempoolClientError::MempoolError(_err)) => {
                    panic!("No such error can occur on 'has_tx_from_address'")
                }

---

crates/starknet_gateway/src/gateway.rs line 147 at r1 (raw file):

        let skip_validate =
            skip_stateful_validations(&executable_tx, account_nonce, self.mempool_client.clone())
                .await;

why did you extract the skip validate logic from run_validate?

Code quote:

        let skip_validate =
            skip_stateful_validations(&executable_tx, account_nonce, self.mempool_client.clone())
                .await;

[Yael-Starkware]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @ArniStarkware)

---

crates/starknet_gateway/src/stateful_transaction_validator_test.rs line 155 at r1 (raw file):

        should_skip_validate
    );
}

lets add a test where has_tx_from_address() returns false

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-12T13:40:48Z

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 5 unresolved discussions (waiting on @Yael-Starkware)

---

crates/starknet_gateway/src/gateway.rs line 147 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

why did you extract the skip validate logic from run_validate?

Done. Reverted.

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 138 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I think we should return the error, as any other error.

Still a WIP.

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 141 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

not sure I'd assert it, since the mempool implementation can change over time.

Done.Still a WIP.

---

crates/starknet_gateway/src/stateful_transaction_validator_test.rs line 155 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

lets add a test where has_tx_from_address() returns false

Done.

---

-- commits line 2 at r2:

Suggestion:

367229c: feat(starknet_gateway): use has tx from address to skip validate

[Yael-Starkware]

Reviewed 2 of 4 files at r3, all commit messages.
Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @ArniStarkware)

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 138 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Still a WIP.

I didn't realize it is so complicated.
maybe it is good enough to just return unexpected error.
lets talk f2f

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 141 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Done.Still a WIP.

same

[Yael-Starkware]

Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @ArniStarkware)

---

crates/starknet_gateway/src/stateful_transaction_validator.rs line 138 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I didn't realize it is so complicated.
maybe it is good enough to just return unexpected error.
lets talk f2f

after discussing f2f,
we decided to return here unexpected error and in a different PR fix the mempool_client_result_to_gw_spec_result return value in case of P2pPropagatorClientError, which will enable us to use it here.