Fix executable node/mjml-cli path checks #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression in 00db9a9 broke setups that depended on PATH environment variables to execute the given node and MJML CLI binaries (`MJML_NODE_PATH` and `MJML_CLI_PATH` environment configurations). Various combinations with `npx`, `nvm`, `pnpm dlx` broke. This commit introduces a more intelligent check using `is_executable` and all PATH environment prefixes that should guarantee that an executable will still be found. A convenient wrapper has been introduced via a private `MJMLService::isExecutable` method. Fixes superbigco#26
|
Thanks @soulseekah, change makes sense to me. I haven't had time to test it personally, but looks good on the tin, so I will merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression in 00db9a9 broke setups that depended on PATH environment variables to execute the given node and MJML CLI binaries (
MJML_NODE_PATHandMJML_CLI_PATHenvironment configurations).Various combinations with
npx,nvm,pnpm dlxbroke.This commit introduces a more intelligent check using
is_executableand all PATH environment prefixes that should guarantee that an executable will still be found. A convenient wrapper has been introduced viaMJMLService::isExecutable.Fixes #26