fix: remove language:Go from search query #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
reviewed
Jun 24, 2024
There was a problem hiding this comment.
From 429 to 434 results without language:Go.
To see all repository without language:Go :
https://github.com/search?q=topic%3Atraefik-plugin+archived%3Afalse+is%3Apublic+-language%3AGo+&type=repositories
I suggest to
- remove
traefik-plugintopic fromtraefik/seo-doc - filter out
deas/teectlandGDGVIT/securum-exirewhich are not plugins
|
I suggest not removing the constraints but creating a specific label and a second search query. |
|
@ldez thanks for your feedback. I have added a new condition to skipped yaegi plugins that are not developed in Go. It avoid to create a second query. I don't see the benefit to create a second search query and a new label |
mloiseleur
reviewed
Jun 26, 2024
| @@ -273,6 +273,11 @@ func (s *Scrapper) process(ctx context.Context, repository *github.Repository) ( | |||
| } | |||
|
|
|||
| default: | |||
| if repository.GetLanguage() != "Go" { | |||
| log.Info().Str("repo_name", repository.GetFullName()).Msg("Yaegi plugin is not developed in Go") | |||
There was a problem hiding this comment.
Suggested change
| log.Info().Str("repo_name", repository.GetFullName()).Msg("Yaegi plugin is not developed in Go") | |
| log.Info().Str("repo_name", repository.GetFullName()).Msg("This plugin is not developed in Go") |
mloiseleur
approved these changes
Jun 26, 2024
|
Closed in favor of #66 |
mmatur
added
resolution/declined
and removed
bot/no-merge
kind/bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr removes the
language:Gofrom query searchFixes #57
Related to: traefik/plugindemowasm#6