Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove language:Go from search query #58

Closed
wants to merge 2 commits into from
Closed

fix: remove language:Go from search query #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df374c3
fix: remove language:Go from search query
mmatur Jun 12, 2024
0ef0c61
fix: skipped yaegi plugin is langage is not Go
mmatur Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/core/scrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const (
const (
// searchQuery the query used to search plugins on GitHub.
// https://help.github.com/en/github/searching-for-information-on-github/searching-for-repositories
searchQuery = "topic:traefik-plugin language:Go archived:false is:public"
searchQuery = "topic:traefik-plugin archived:false is:public"

// searchQueryIssues the query used to search issues opened by the bot account.
searchQueryIssues = "is:open is:issue is:public author:traefiker"
Expand Down Expand Up @@ -273,6 +273,11 @@ func (s *Scrapper) process(ctx context.Context, repository *github.Repository) (
}

default:
if repository.GetLanguage() != "Go" {
log.Info().Str("repo_name", repository.GetFullName()).Msg("Yaegi plugin is not developed in Go")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Info().Str("repo_name", repository.GetFullName()).Msg("Yaegi plugin is not developed in Go")
log.Info().Str("repo_name", repository.GetFullName()).Msg("This plugin is not developed in Go")

return nil, nil
}

pluginName, versions, err = s.verifyYaegiPlugin(ctx, repository, latestVersion, manifest)
if err != nil {
span.RecordError(err)
Expand Down