Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Minecraft 1.20.1 #358

Merged
merged 12 commits into from
Jun 13, 2023
Merged

Update to Minecraft 1.20.1 #358

merged 12 commits into from
Jun 13, 2023

Conversation

dyc3
Copy link
Collaborator

@dyc3 dyc3 commented Jun 7, 2023 •
edited
Loading

Description

Updates valence to Minecraft 1.20.1, which is protocol compatible with 1.20.

closes #357

@rj00a
Copy link
Member

rj00a commented Jun 7, 2023

Thanks for working on this.

I have no idea why its not building right now.

The entity extractor is a bit buggy and the way it handles tracked data is incorrect. The output is nondeterministic which causes some weirdness. If you change 0 air to 1 air in the generated entities.json it should pass the assertion in the build script for now.

@dyc3
Copy link
Collaborator Author

dyc3 commented Jun 8, 2023 •
edited
Loading

The output is nondeterministic.

That's definitely a problem, I'll open an issue for it: #359

@dyc3
Copy link
Collaborator Author

dyc3 commented Jun 8, 2023

I'm getting this for the block_entities example:

the trait bound `Value: From<valence::prelude::Uuid>` is not satisfied

Seems weird. Did we have this impl before?

@rj00a
Copy link
Member

rj00a commented Jun 8, 2023

Seems weird. Did we have this impl before?

I think I changed the default feature flags for valence_nbt in the top-level Cargo.toml. Try adding the uuid feature to it.

@rj00a
Copy link
Member

rj00a commented Jun 8, 2023

Not sure why it's producing an error now though.

@dyc3
Copy link
Collaborator Author

dyc3 commented Jun 8, 2023 •
edited
Loading

Just tried connecting with the chest example on 1.20 and it didn't work. Haven't looked into it yet.

This might have something to do with it

image

@dyc3
Copy link
Collaborator Author

dyc3 commented Jun 8, 2023 •
edited
Loading

I don't think I have enough context about how the connection handshake works to continue debugging this, but it seems like something changed with packet decoding.

image

Appears to be thrown in DecoderHandler.java on line 43

@rj00a
Copy link
Member

rj00a commented Jun 8, 2023

Packet definitions likely changed. Packet inspector would help debug but that's out of commission. Otherwise println! and thread::sleep until the bad packets are found.

@rj00a
Copy link
Member

rj00a commented Jun 12, 2023

Update 1.20 diff on wiki.vg

@dyc3
Copy link
Collaborator Author

dyc3 commented Jun 12, 2023

I believe the packet that causes the error is LoginSuccessS2c

@Jenya705 Jenya705 mentioned this pull request Jun 13, 2023
Merged
1.20.1 (#365)
75c1a34 
## Description

Describe the changes you've made. Link to any issues this PR fixes or
addresses.

Into the mc-1.20 branch for now, can change to main if desired. got this
to connect/play on the conway example on a 1.20.1 client

(most credits go to dyc ofc)
@dyc3 dyc3 changed the title Update to Minecraft 1.20 Update to Minecraft 1.20.1 Jun 13, 2023
@dyc3 dyc3 marked this pull request as ready for review June 13, 2023 19:52
@dyc3 dyc3 requested a review from rj00a June 13, 2023 19:52
@rj00a rj00a merged commit 09fbd9b into main Jun 13, 2023
@rj00a rj00a deleted the mc-1.20 branch June 13, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rj00a rj00a Awaiting requested review from rj00a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to 1.20
2 participants
@dyc3 @rj00a