Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VE.Bus inverter support #1806

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Improve VE.Bus inverter support #1806

merged 3 commits into from
Dec 20, 2024

Conversation

martinbosma
Copy link
Contributor

Some items were visible for inverters while not applicable, such as active input and AC phase data. I copied the behavior mainly from gui-v1.

@martinbosma martinbosma added the bug Something isn't working label Dec 18, 2024
@martinbosma martinbosma requested a review from blammit December 18, 2024 11:07
Copy link
Contributor

@blammit blammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so a vebus service could be an inverter/charger, or just a plain inverter, is that right? I had thought that plain inverters would use the inverter service, but maybe that is only for older products?

@martinbosma
Copy link
Contributor Author

Correct, and the vebus inverters are actually the older products but still being produced.

@blammit
Copy link
Contributor

blammit commented Dec 20, 2024

Looks okay to merge, will merge now to put this into the release.

@blammit blammit merged commit 63aef88 into main Dec 20, 2024
2 checks passed
@blammit blammit deleted the martin/vebus-inverter branch December 20, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants