Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VE.Bus inverter support #1806

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Improve VE.Bus inverter support #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
014c27c
PageVebus: hide SoC and active input for inverters
martinbosma Dec 18, 2024
aae751e
PageVebusAdvanced: hide equalization for inverters
martinbosma Dec 18, 2024
260c90b
VeBusAcIODisplay: hide phase data for inverters
martinbosma Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/VeBusAcIODisplay.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,20 @@ Loader {
property string serviceUid

width: parent ? parent.width : 0
sourceComponent: numberOfPhases.value === 1 ? singlePhaseAcInOut
sourceComponent: numberOfAcInputs.value === 0 ? null
: numberOfPhases.value === 1 ? singlePhaseAcInOut
: numberOfPhases.value === 3 ? threePhaseTables : null

VeQuickItem {
id: numberOfPhases
uid: root.serviceUid + "/Ac/NumberOfPhases"
}

VeQuickItem {
id: numberOfAcInputs
uid: root.serviceUid + "/Ac/NumberOfAcInputs"
}

Component {
id: singlePhaseAcInOut

Expand Down
2 changes: 2 additions & 0 deletions pages/vebusdevice/PageVeBus.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ Page {
}

ListQuantity {
allowed: defaultAllowed && root.isMulti
dataItem.uid: root.bindPrefix + "/Soc"
text: CommonWords.state_of_charge
unit:VenusOS.Units_Percentage
Expand All @@ -238,6 +239,7 @@ Page {
}

ListActiveAcInput {
allowed: defaultAllowed && root.isMulti
bindPrefix: root.bindPrefix
}

Expand Down
1 change: 1 addition & 0 deletions pages/vebusdevice/PageVeBusAdvanced.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ Page {
return qsTrId("vebus_device_press_to_start")
}
enabled: !isNaN(setChargerState.value) && !isNaN(vebusSubState.value) && !startTimer.running && !interruptTimer.running
allowed: defaultAllowed && root.isMulti

onClicked: {
if (firmwareVersion.value < 0x400) {
Expand Down
Loading