Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and related fixes: lerna v8, prettier v3, react-scripts v5, storybook v8 #1419

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

MurakamiShinyu
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vivliostyle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 3:48pm

@MurakamiShinyu MurakamiShinyu marked this pull request as draft November 14, 2024 17:07
@MurakamiShinyu MurakamiShinyu marked this pull request as ready for review November 15, 2024 16:31
@MurakamiShinyu MurakamiShinyu merged commit 7fe5b97 into master Nov 15, 2024
5 checks passed
@MurakamiShinyu MurakamiShinyu deleted the update-deps branch November 15, 2024 16:31
MurakamiShinyu added a commit that referenced this pull request Nov 17, 2024
This fixes the following problems:

- "TypeError: Cannot read properties of undefined" occurred in Renderer.stories.js
- docs.autodocs setting that was added by `npx storybook@latest upgrade` in PR #1419 is not needed and commented out.
MurakamiShinyu added a commit that referenced this pull request Nov 17, 2024
This fixes the following problems:

- "TypeError: Cannot read properties of undefined" occurred in Renderer.stories.js
- docs.autodocs setting that was added by `npx storybook@latest upgrade` in PR #1419 is not needed and commented out.
- "build-dev" in packages/core did not generate type definitions and build-dev failed in packages/react.
- microbundle-crl is old and not maintained, so it should be replaced with microbundle.
MurakamiShinyu added a commit that referenced this pull request Nov 17, 2024
This fixes the following problems:

- "TypeError: Cannot read properties of undefined" occurred in Renderer.stories.js
- docs.autodocs setting that was added by `npx storybook@latest upgrade` in PR #1419 is not needed and commented out.
- "build-dev" in packages/core did not generate type definitions and build-dev failed in packages/react.
- microbundle-crl is old and not maintained, so it should be replaced with microbundle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant