Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLM] Avoid unnecessary tokenization #12310

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jan 22, 2025

Instead of tokenizing the string mm_token * token_count, we can first tokenize mm_token by itself to mm_token_id before repeating it. This reduces the time to run the processing tests in test_common.py from 18 mins to 12 mins on my machine.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 22, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from ywang96 January 22, 2025 09:14
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

On a side note - I think it can be sometimes confusing that we're using the same interface for replacing prompt and prompt token ids. I don't think we should create more subclasses/interfaces, but it would be great to have examples under the documentation of PromptReplacement to make it more developer-friendly.

@DarkLight1337
Copy link
Member Author

LGTM!

On a side note - I think it can be sometimes confusing that we're using the same interface for replacing prompt and prompt token ids. I don't think we should create more subclasses/interfaces, but it would be great to have examples under the documentation of PromptReplacement to make it more developer-friendly.

Yeah I'm planning to add more docs soon.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 22, 2025 09:36
@DarkLight1337 DarkLight1337 merged commit cd7b6f0 into vllm-project:main Jan 22, 2025
50 checks passed
@DarkLight1337 DarkLight1337 deleted the token-id branch January 22, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants