Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Create method to BasicReport #1994

Open
wants to merge 3 commits into
base: kungfucraig/mcapiphaseone
Choose a base branch
from

Conversation

kungfucraig
Copy link
Member

@kungfucraig kungfucraig commented Jan 8, 2025

Changes to the MC API required for Phase II.

@wfa-reviewable
Copy link

This change is Reviewable

@kungfucraig kungfucraig changed the base branch from main to kungfucraig/mcapiphaseone January 8, 2025 18:16
@kungfucraig kungfucraig changed the title feat: Add protos for MC API Phase II feat: Add Create method to BasicReport Jan 8, 2025
@kungfucraig kungfucraig force-pushed the kungfucraig/mcapiphasetwo branch from e0f1e3b to a919516 Compare January 9, 2025 18:26
@kungfucraig kungfucraig force-pushed the kungfucraig/mcapiphasetwo branch from ad25ae1 to 3739a5b Compare January 9, 2025 18:45
Copy link
Member Author

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants