fix accumulated_occurrences reset before notify

wyeworks · Aug 23, 2024 · e5c7693 · e5c7693
1 parent 5eac749
commit e5c7693
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/boom_notifier/notification_sender.ex b/lib/boom_notifier/notification_sender.ex
@@ -31,10 +31,10 @@ defmodule BoomNotifier.NotificationSender do
 
   def notify_all(settings, error_info) do
     notification_trigger = Keyword.get(settings, :notification_trigger, :always)
-    ErrorStorage.reset_accumulated_errors(notification_trigger, error_info)
-
     occurrences = Map.put(error_info, :occurrences, ErrorStorage.get_error_stats(error_info))
 
+    ErrorStorage.reset_accumulated_errors(notification_trigger, error_info)
+
     BoomNotifier.Api.walkthrough_notifiers(
       settings,
       fn notifier, options -> notify(notifier, occurrences, options) end

diff --git a/test/unit/notification_sender_test.exs b/test/unit/notification_sender_test.exs
@@ -80,6 +80,14 @@ defmodule BoomNotifier.NotificationSenderTest do
       refute_receive({:notify_called, _}, @receive_timeout)
       assert {:schedule, @throttle_timeout} = trigger_notify_resp
     end
+
+    test "sends notification occurrences along error info", %{error_info: error_info} do
+      for _ <- 1..7 do
+        NotificationSender.trigger_notify(@settings_groupping, error_info)
+      end
+
+      assert_receive({:notify_called, %{occurrences: %{accumulated_occurrences: 4}}})
+    end
   end
 
   describe "async call with exponential notification trigger" do