Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off the sync service #11

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Split off the sync service #11

merged 5 commits into from
Dec 4, 2024

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Dec 4, 2024

Separate deployment for the sync service. Same as the api service it has two replicas.

Enable the metrics endpoint for both.

Use the metrics endpoint as a readiness check for the sync api.

@mkysel mkysel requested review from neekolas and fbac December 4, 2024 18:40
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we want 2 replicas in the public examples. I get it for our own testnet, where we want to find edge cases. But most users should be happy with 1 sync service that scales to 2 only during deployment.

@mkysel
Copy link
Collaborator Author

mkysel commented Dec 4, 2024

Sure. I can adjust down to 1.

@mkysel mkysel requested a review from neekolas December 4, 2024 19:15
@mkysel mkysel merged commit 16df6cb into main Dec 4, 2024
5 checks passed
@mkysel mkysel deleted the mkysel/sync-service-split branch December 4, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants