doc: contribute: remove need to fix new style immediately #84178
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to review of commit ea4e46d ("doc: contribute: Extend Reviewer Expectations with additional rules") where this was already discussed. It is not really realistic to request that new guidelines be applied immediately all across the tree immediately and it would also go against the "smaller PRs" guideline. It should be possible to implement new rules more gradually. Also clarify that new rules can be enforced only after they've been merged. Signed-off-by: Marc Herbert <[email protected]>
de-nordic
reviewed
Jan 18, 2025
Comment on lines
+373
to
+375
| a reason for a request for changes. The reviewer can optionally propose and | ||
| document new guidelines or rules, and then enforce them after they've been | ||
| evaluated, reviewed, agreed and merged. |
There was a problem hiding this comment.
Question: wouldn't it be better to move the clause to the section starting at line 377?
Since we point there that reviewers should be able to list out the rules/guidelines, we may also mention that if there is no such rule then reviewer is allowed to form one? Any opinions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to review of commit ea4e46d ("doc: contribute: Extend Reviewer Expectations with additional rules") where this was already discussed.
It is not really realistic to request that new guidelines be applied immediately all across the tree and it would also go against the "smaller PRs" guideline. It should be possible to implement new rules more gradually.
Also clarify that new rules can be enforced only after they've been merged.