Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: contribute: remove need to fix new style immediately #84178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

doc: contribute: remove need to fix new style immediately #84178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/contribute/contributor_expectations.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,9 @@ Reviewer Expectations

- Style changes that the reviewer disagrees with but that are not documented as
part of the project can be pointed out as non-blocking, but cannot constitute
a reason for a request for changes. The reviewer can optionally correct any
potential inconsistencies in the tree, document the new guidelines or rules,
and then enforce them as part of the review.
a reason for a request for changes. The reviewer can optionally propose and
document new guidelines or rules, and then enforce them after they've been
evaluated, reviewed, agreed and merged.
Comment on lines +373 to +375
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: wouldn't it be better to move the clause to the section starting at line 377?
Since we point there that reviewers should be able to list out the rules/guidelines, we may also mention that if there is no such rule then reviewer is allowed to form one? Any opinions?


- Whenever requesting style related changes, reviewers should be able to point
out the corresponding guideline, rule or rationale in the project's
Expand Down
Loading