Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for body being nullish or empty #4

Open
wants to merge 1 commit into
base: feature/support-drafts
Choose a base branch
from

Conversation

greglockwood
Copy link
Owner

@greglockwood greglockwood commented Jan 9, 2021

PR Description
realyze#30 Added ability to customise the base branch
#3 Fixed bug where branches were always being pushed
👉 #4 Cater for body being nullish or empty
#5 Added support for table format for TOC
#6 Added support to print links to PRs in terminal
#7 Work when remote URL doesn't have .git suffix
realyze#31 [combined branch] Combined changes

Which problem does this PR solve?

This is my attempt to fix issue realyze#19.

Main changes

Added handling for body being nullish.

How I tested it works

TBH, I didn't. But this should resolve the exception mentioned in realyze#19.

@greglockwood greglockwood force-pushed the fix/npe-when-body-undefined branch 3 times, most recently from 1c5dec2 to 9b06836 Compare January 9, 2021 15:20
@greglockwood greglockwood changed the title Cater for body being nullish or empty Fixes #19 Cater for body being nullish or empty Jan 11, 2021
@greglockwood greglockwood requested a review from realyze January 11, 2021 08:48
@greglockwood greglockwood marked this pull request as ready for review January 11, 2021 08:48
@greglockwood greglockwood force-pushed the feature/support-drafts branch from ed49e02 to e83af0e Compare January 18, 2021 09:17
@greglockwood greglockwood force-pushed the fix/npe-when-body-undefined branch from 9b06836 to b55bc33 Compare January 18, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants