Work when remote URL doesn't have .git suffix #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2021
Open
greglockwood
force-pushed
the
feature/work-without-git-remote-extension
branch
from
fb45682 to
3aa9f37
Compare
greglockwood
force-pushed
the
feature/print-pr-links
branch
from
9733a6c to
c858241
Compare
greglockwood
force-pushed
the
feature/work-without-git-remote-extension
branch
3 times, most recently
from
b78f1df to
dcd276e
Compare
realyze
approved these changes
Jan 15, 2021
greglockwood
force-pushed
the
feature/print-pr-links
branch
from
c5c40a1 to
fd941be
Compare
greglockwood
force-pushed
the
feature/work-without-git-remote-extension
branch
from
dcd276e to
0f03fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does this PR solve?
I discovered when I was testing on my fork, which had a git remote URL of
https://github.com/greglockwood/pr-train, without the.gitextension, that the current code incorrectly assumed that the remote URL ended in.git.Main changes
Tweaked the code to not require the
.gitextension when extracting the nickname and repo (but remove it if it is there).How I tested it works
I managed to use
pr-trainon my fork (at least initially). It doesn't seem to really support chains of PRs across forks.