My combined fixes for a few issues #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2021
# Conflicts: # cfg_template.yml # index.js
# Conflicts: # index.js
# Conflicts: # cfg_template.yml # consts.js # github.js # index.js
greglockwood
force-pushed
the
greglockwood/combined-changes
branch
from
dcd276e to
0f03fb9
Compare
|
@realyze I updated this over the weekend with all of your suggested changes on my PRs. I don't know what your versioning strategy is with changes like these. If you're happy with the result, feel free to merge it and bump the version as you see fit. |
|
Hi @greglockwood , sorry for the delay, lots of things came up; I will have another look this week! Thanks again. |
realyze
reviewed
Jan 30, 2021
|
Thanks a lot for the PRs @greglockwood , I merged in your change and published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Fixes #17
Fixes #19
Fixes #24
Fixes #25
Combines all changes from individual PRs in the train shown above.