Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_integration_tests): refactor create_state_sync_config to create multi configs #3259

Closed
wants to merge 1 commit into from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Jan 12, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/ae506be9 to main January 12, 2025 14:28
@nadin-Starkware nadin-Starkware changed the title refactor(starknet_integration_test): refactor create_state_sync_config to create multi state_sync configs refactor(starknet_integration_tests): refactor create_state_sync_config to create multi state_sync configs Jan 12, 2025
@nadin-Starkware nadin-Starkware changed the title refactor(starknet_integration_tests): refactor create_state_sync_config to create multi state_sync configs refactor(starknet_integration_tests): refactor create_state_sync_config to create multi configs Jan 12, 2025
@nadin-Starkware nadin-Starkware force-pushed the spr/main/da683768 branch 4 times, most recently from cf93274 to e94ac31 Compare January 13, 2025 08:46
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/utils.rs line 95 at r1 (raw file):

    let state_sync_config =
        create_state_sync_configs(state_sync_storage_config, available_ports.get_next_ports(1))
            .remove(0);

Why?

Code quote:

        create_state_sync_configs(state_sync_storage_config, available_ports.get_next_ports(1))
            .remove(0);

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/utils.rs line 95 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Why?

Specifically why remove(0)

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/utils.rs line 339 at r1 (raw file):

    let mut state_sync_configs = vec![];
    let network_configs = create_connected_network_configs(ports);
    for network_config in network_configs {

use into_iter syntax to create the state sync configs, and then collect them to obtain the required returned vector

Code quote:

network_configs

…ig to create multi configs

commit-id:da683768
Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)


crates/starknet_integration_tests/src/utils.rs line 95 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Specifically why remove(0)

Since create_state_sync_configs returns a Vec<StateSyncConfig>, but SequencerNodeConfig expects only a single StateSyncConfig.


crates/starknet_integration_tests/src/utils.rs line 339 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

use into_iter syntax to create the state sync configs, and then collect them to obtain the required returned vector

Done.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware
Copy link
Collaborator Author

✓ Commit merged in pull request #3261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants