-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(starknet_integration_tests): refactor create_state_sync_config to create multi configs #3259
Conversation
61a0d87
to
cbb2a30
Compare
cbb2a30
to
1e07f82
Compare
1e07f82
to
8d1e28d
Compare
cf93274
to
e94ac31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/utils.rs
line 95 at r1 (raw file):
let state_sync_config = create_state_sync_configs(state_sync_storage_config, available_ports.get_next_ports(1)) .remove(0);
Why?
Code quote:
create_state_sync_configs(state_sync_storage_config, available_ports.get_next_ports(1))
.remove(0);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/utils.rs
line 95 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Why?
Specifically why remove(0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/utils.rs
line 339 at r1 (raw file):
let mut state_sync_configs = vec![]; let network_configs = create_connected_network_configs(ports); for network_config in network_configs {
use into_iter
syntax to create the state sync configs, and then collect
them to obtain the required returned vector
Code quote:
network_configs
e94ac31
to
c364cfe
Compare
…ig to create multi configs commit-id:da683768
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/utils.rs
line 95 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Specifically why
remove(0)
Since create_state_sync_configs
returns a Vec<StateSyncConfig>
, but SequencerNodeConfig
expects only a single StateSyncConfig
.
crates/starknet_integration_tests/src/utils.rs
line 339 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
use
into_iter
syntax to create the state sync configs, and thencollect
them to obtain the required returned vector
Done.
c364cfe
to
23133a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
✓ Commit merged in pull request #3261 |
Stack: