Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_integration_tests): support running a node with a delay in the integration test #3271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Jan 13, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/sequencer_manager.rs line 78 at r1 (raw file):

                    sequencer_setup.node_config_path.clone(),
                    sequencer_setup.sequencer_execution_id.into(),
                    sequencer_setup.delay_in_sec,

Please handle the delay here, this is part of the test, not part of running the node. There's a tokio struct called timeout that might be handy.

Code quote:

sequencer_setup.delay_in_sec,

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/0a4937c9 to main January 13, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants