Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_integration_tests): enable state sync in integration test #3261

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Jan 12, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/da683768 to main January 13, 2025 12:38
@nadin-Starkware nadin-Starkware added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit d6ecbe4 Jan 13, 2025
14 checks passed
@ShahakShama
Copy link
Contributor

crates/starknet_integration_tests/src/flow_test_setup.rs line 141 at r2 (raw file):

        let component_config = ComponentConfig::default();

        let state_sync_config = create_state_sync_configs(

This means that the state sync isn't connected in the flow test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants