-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Notification delivery throttling timeout #92
[Feature] Notification delivery throttling timeout #92
Conversation
742e272
to
b5ae6d7
Compare
80590c8
to
729c952
Compare
8bfea51
to
5eac749
Compare
e5c7693
to
b3fd0af
Compare
Make accumulated_occurrences testing more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been taking a look at the code in general and I think looks good overall 🙌
Apart from that, I think we should take a look at the String.to_existing_atom/1
thing and to the way we retrieve the error occurrences when resetting the accumulated errors. I still have to take a closer look at the NotificationSender
but I suspect we may introduce a race condition if we don't retrieve the occurrences and reset the accumulated errors in an atomic step for the ErrorStorage
agent (let's say that some other process is storing a new error occurrence while the sender is resetting it).
I'll be taking a deep look at the notification sender process later and I've left some suggestions to try to keep a consistent use of the pipe operator.
Great work 🙌
@joaquinco Thanks for taking your time for implementing this 🚀 |
I'm gonna let you @germanbottosur do the approval since you've been working more closely on this 💖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Introduction
Allow users to specify a timeout for notification deliveries that are hold off by some
notification_trigger
counting strategy.Changes
BoomNotifier
module by just defining wrapper functions of the notify_error related logic (now inBoomNotifier.Api
) with a specific configuration.