Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha bugs list #1

Closed
54 of 66 tasks
tzarebczan opened this issue Jul 29, 2021 · 19 comments
Closed
54 of 66 tasks

Alpha bugs list #1

tzarebczan opened this issue Jul 29, 2021 · 19 comments
Assignees
Labels
bug Something isn't working Epic

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Jul 29, 2021

  • password not validated or saved on sign up - can't continue sign in
  • color theme on description is LBRY green (hyperlinks / tags)
  • blue ribbon at top of wallet page goes to rewards page that doesn't work. Blue ribbon is not within color theme.
  • remove USD equivalents ?
  • channel discover page doesn't load - this should load channels from primary category, sorted by trending?
  • should be able to click entire comment to expand all comments, not just the expand button.
  • Improve single comment picking. It is just selecting comment 0, even if it won't be displayed on expanded list
  • when signed out, drive sign up if you try to react, comment, etc.
  • When no channel available and required, drive channel creation
  • comments page on channel page shows bad data - check @saltycracker channel, only has 1 comment
  • no search / url bar?
  • when you sign out, wallet balance still shows, notification page blank
  • Bittrex conversion link > https://lbry.com/faq/exchanges. Call it "Exchange your Credits" - or ask Jeremy for the Copy for this.
  • Can't comment: authentication required
  • After reacting, comments collapse. Can't see total reactions after you react. (can't seem to react anymore)
  • Clicking video from pop out player goes to homepage.
  • Can't navigate home after a few videos deep via related.(have to keep clicking back through each page).
  • New content notification click ends up in 'loading decentralized data for a while (no need to mention decentralized mention). Other navigation steps too, even after being available in claim search.
  • on sign up, email sent to is black, can't see the email
  • Odysee often disappears from the quick switcher - need to find the app again. Happens when I navigate away to another app? This happens on the sign in page for sure (i..e go to check email for confirmation link, disappears)
  • view more on wallet page expands to a blank item (no additional breakdown shown)
  • remove all references to USD stuff
  • app crash with samsung
  • changes to followings in app seem to only be stored locally (wallet sync is off, added to top missing features)
  • has option to follow channels you are already following
  • Following page feels bloated(top bar + channels you follow + navigation bar takes about half of the screen )
  • view history (sign out or view + sign in - should clear maybe?), including notifications is persisted between sessions
  • floating player covers navigation bar at the bottom
  • resolve notification data to get channel and claim thumbnails for notifications area
  • fireabase token persisted between uninstall/reinstall. Getting old notifications from the previous account. Never saw this before - apis issue?
  • pop out player gets stuck to top of trending somehow (notice it's both at the top and bottom - small thumbnail, I was scrolled up)
    image
  • pop out player shows on non-video content (minimize while on random page)
    image
  • Livestreams are no longer listed on the Following fragment
  • Make progress bar Odysee theme
  • Julian got stuck at "retrieving account information" - had to close/reopen
  • Julian getting random crashes, doesn't seem consistent on anything in particular. I got a few while navigating around as well.
  • remove details on sign in about wallet sync (streamline)
  • search both content and channels for top result (i..e thomas.zarebczan would search @thomas.zarebczan) (julian noticed this)
  • you can get the bottom navigation items to show during search, but clicking them doesn't do anything
  • auto search after typing + waiting x seconds?
  • allow magic link login on the password prompt.
  • playlists on channel page - look strange without thumbnail, cannot view content error when clicking one without thumbnail. With thumbnail, it shows the thumbnail on top and loading icon over it, and then the typical file view. playlist items are way at the bottom. Probably want to start without the details page and just show the playlist items, with current item playing on top.
  • livestreams don't play (tried direct link - probably needs urls updated to odysee ones)
  • notifications are marked read only in the session - when I quit app + restart, I see 50+ on bell, and those I recently watched are not marked as read anymore.
  • search shows a spinning bar in top right even if you aren't searching anything
  • remove search text "you can search..." - match ios - "start typing to discover" with lasso spaceman
  • Make commenting flow colors odysee theme (saw green stuff)
  • Make search flow Odysee colors (green on channel links)
  • reacting to content is super slow - count does not increment.
  • notifications page takes over other pages, no clear way to close besides clicking back. If you click notification, and then search, it shows the search box with notifications in backgroud
  • authentication error when tipping
  • swipe gestures close app (Akin thinks this may be causing what Julian is seeing)
  • remove "loading decentralized data" references
  • Odysee notification icon - make Odysee colors (it's green today)

missing features:

  • wallet sync
  • reward verification via phone/twitter/cc/paid
  • livestreams (showing on channel page , live stream comments at least)
  • yt sync flow
  • first run flow (claiming email verified reward or maybe the android one we have - both are fine too, channel setup or YT sync, follow channels)
  • comment reactions
  • rewards
  • channel creation
  • checking for disabled comments on channels (see ios implementation)
  • playlists

Will add more here as I find it, anyone else is free to edit/add also.

Fixed:

  • Blank trending homepage when navigating back to it. Clicking new (loads) and then trending again works. Categories are lost in this case.
  • sign in goes to a sign up flow. Add option to sign in?
  • Sign in proces shows "join odysee"
  • buy LBRY credits pops up a strange overlay. This can probably be modeled after odysee.com buy screen or remove for now.
  • yerbil > space man
  • user and install new needs to pass odysee.com as the domain - otherwise you get LBRY related emails
  • wildwest > all content, don't pass any channel ids + only allow trending
  • Makes my notification bar black, can't see any icons/text. (Phone in dark mode).
  • seek bar on video is LBRY themed
  • are we optimizing spee.ch thumbnails to a reasonable size? maybe use the ones that odysee.com is using so they are properly cached. Lazy loading feels sluggish
  • Share buttons link to lbry.tv, should by odysee.com
  • Wallet: "View All" shows incorrectly "There are no transactions to display"

Some new stuff from the recent beta (12/17):

  • reports of crashing on email verification
  • can't see comments after posting
  • need comment edit/delete options
  • wild west still looks filtered (that was checked off above)
  • thumbnails not loading in notifications
  • Fix odysee colors on wallet page (green)
  • Remove "exchange your credits" link
  • when supporting and entering an amount, need to click into field twice to get keyboard to pop up
  • livestreams not brought to top of channel page. Need to account for scheduled streams also.
@tzarebczan
Copy link
Contributor Author

tzarebczan commented Aug 23, 2021

moved to top

@iamflorencejay
Copy link

By the way, AsyncTask is deprecated in Android 11, so I see the problem here.

@PeterKW
Copy link

PeterKW commented Aug 26, 2021

Does it have the ability to play through playlists yet like the website and LBRY Desktop? https://odysee.com/$/lists

@keikari
Copy link

keikari commented Aug 27, 2021

App "just crashes" on some devices.
Specs:

Also happens for someone on android 7.1.1, don't have other details.

Edit: Few more crashes at launch

Also on Samsung S7 Android 8.0

@Mesum-Hussain
Copy link

Mesum-Hussain commented Aug 27, 2021

Facing difficulty while cloning the project.
Seems there is some problem with some file 'twitter.properties'.
Screenshot from 2021-08-27 21-14-31

Any guidance would be highly appreciated.

@akinwale
Copy link
Contributor

image

I've seen a certificate error when installing the package. Probably on APK build.

Try this build. Older builds did not have v2 signing enabled. Subsequent builds will have this option.
https://build.lbry.io/android/odysee-build-13_commit-12ad5c4/odysee-0.0.11-release.apk

@akinwale
Copy link
Contributor

Facing difficulty while cloning the project.
Seems there is some problem with some file 'twitter.properties'.
Screenshot from 2021-08-27 21-14-31

Any guidance would be highly appreciated.

Create a twitter.properties text file in the app/ folder with the following content:

twitterConsumerKey=
twitterConsumerSecret=

@Mesum-Hussain
Copy link

Mesum-Hussain commented Aug 27, 2021

Facing difficulty while cloning the project.
Seems there is some problem with some file 'twitter.properties'.
Screenshot from 2021-08-27 21-14-31
Any guidance would be highly appreciated.

Create a twitter.properties text file in the app/ folder with the following content:

twitterConsumerKey=
twitterConsumerSecret=

Thanks. working now. 🙂

@kekkyojin
Copy link
Collaborator

By the way, AsyncTask is deprecated in Android 11, so I see the problem here.

That's unrelated to the signature problem.

AsyncTask was deprecated, but not yet removed. All my new code was also using Java Futures instead of AsyncTask

@iamflorencejay
Copy link

By the way, AsyncTask is deprecated in Android 11, so I see the problem here.

That's unrelated to the signature problem.

AsyncTask was deprecated, but not yet removed. All my new code was also using Java Futures instead of AsyncTask

I see. But I think it will be removed in the future though. So yep, patch it up.

@keikari
Copy link

keikari commented Aug 30, 2021

moved to top

@julianchandra
Copy link

julianchandra commented Sep 2, 2021

Feature request for first run:
Ability to send tip - if it's taking this long to release, we may as well have this bit ready.

// edit: asked Julian about this lol

@iamflorencejay
Copy link

Feature request for first run:
Ability to send tip - if it's taking this long to release, we may as well have this bit ready.

This will happen probably on Google's in app purchases, not stripe.

@julianchandra
Copy link

julianchandra commented Sep 13, 2021

I've been playing around with odysee android alpha. Probably not ready for release yet.
A couple of things that I noticed that were were problematic:

  1. If I go out of the app even just for a few seconds to check another app and return, the odysee app restarts.

  2. Searching for channels: Search for a channel, e.g. laowhy86, you'll see 'nothing is here' at the top, then the laowhy86 channel, and then some of his videos. If you click the channel below the 'nothing is here' nothing happens. So users can't view channel pages yet

@PeterKW
Copy link

PeterKW commented Sep 20, 2021

Any idea/updates on when private lists will be watchable in the app? https://odysee.com/$/lists

@kekkyojin
Copy link
Collaborator

Livestreams are again listed on the Following fragment. Fixed on branch, will be merged on master branch. This will come along the fix for livestream play and a few of threading API changes -my code was using Future.get(), which was blocking Android UI thread; the branch changes it-. This branch will should also make the content Reaction code faster, as it will no longer block the main thread.

@kekkyojin
Copy link
Collaborator

pop out player gets stuck to top of trending somehow (notice it's both at the top and bottom - small thumbnail, I was scrolled up)

The item on the top is certainly not the same. Mini player -the one at the bottom- is using a explicitly different layout than list items. Also look at the background color.

What is happening is that somehow recyclerview is using the list item's layout for smaller screens for the one on the top. Odysee Android added a new layout for items to be used on more common screens nowadays, which have more pixels available and can show the thumbnail side-to-side of the screen. But the older layout remained, as older or cheaper -with lower resolution- phones can use it instead.

It looks like some graphic artifact from the Android OS.

What shouldn't be happening at all is that top item to be stuck there.

@ghost
Copy link

ghost commented Nov 28, 2021

Are downloads every going to be added?

@akinwale
Copy link
Contributor

Closing this for #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Epic
Projects
None yet
Development

No branches or pull requests

8 participants